From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A099F18048 for ; Sat, 7 Oct 2023 10:50:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=none Received: from Chamillionaire.breakpoint.cc (Chamillionaire.breakpoint.cc [IPv6:2a0a:51c0:0:237:300::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0A6A89E; Sat, 7 Oct 2023 03:50:52 -0700 (PDT) Received: from fw by Chamillionaire.breakpoint.cc with local (Exim 4.92) (envelope-from ) id 1qp4t1-0005zZ-Dj; Sat, 07 Oct 2023 12:50:19 +0200 Date: Sat, 7 Oct 2023 12:50:19 +0200 From: Florian Westphal To: George Guo Cc: edumazet@google.com, davem@davemloft.net, dsahern@kernel.org, kuba@kernel.org, pabeni@redhat.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, George Guo Subject: Re: [PATCH] tcp: fix secure_{tcp, tcpv6}_ts_off call parameter order mistake Message-ID: <20231007105019.GA20662@breakpoint.cc> References: <20231007092337.1540036-1-dongtai.guo@linux.dev> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231007092337.1540036-1-dongtai.guo@linux.dev> User-Agent: Mutt/1.10.1 (2018-07-13) X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_PASS,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net George Guo wrote: > From: George Guo > > Fix secure_tcp_ts_off and secure_tcpv6_ts_off call parameter order mistake Could you please send a v2, targetting net-next, that clearly says that this is a cleanup? [ It doesn't matter if we pass "saddr, daddr" or "daddr, saddr" as long as both "init" and "check" functions agree on the ordering ]