From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: Jakub Kicinski <kuba@kernel.org>
Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
Thomas Gleixner <tglx@linutronix.de>,
Wander Lairson Costa <hawk@kernel.org>
Subject: Re: [PATCH net-next 0/2] net: Use SMP threads for backlog NAPI (or optional).
Date: Sat, 7 Oct 2023 17:59:57 +0200 [thread overview]
Message-ID: <20231007155957.aPo0ImuG@linutronix.de> (raw)
In-Reply-To: <20231004154609.6007f1a0@kernel.org>
On 2023-10-04 15:46:09 [-0700], Jakub Kicinski wrote:
> On Fri, 29 Sep 2023 18:20:18 +0200 Sebastian Andrzej Siewior wrote:
> > - Patch #2 has been removed. Removing the warning is still an option.
> >
> > - There are two patches in the series:
> > - Patch #1 always creates backlog threads
> > - Patch #2 creates the backlog threads if requested at boot time,
> > mandatory on PREEMPT_RT.
> > So it is either or and I wanted to show how both look like.
> >
> > - The kernel test robot reported a performance regression with
> > loopback (stress-ng --udp X --udp-ops Y) against the RFC version.
> > The regression is now avoided by using local-NAPI if backlog
> > processing is requested on the local CPU.
>
> Not what we asked for, and it doesn't apply.
Apologies if I misunderstood. You said to make it optional which I did
with the static key in the second patch of this series. The first patch
is indeed not what we talked about I just to show what it would look
like now that there is no "delay" for backlog-NAPI on the local CPU.
If the optional part is okay then I can repost only that patch against
current net-next.
Sebastian
next prev parent reply other threads:[~2023-10-07 16:00 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-29 16:20 [PATCH net-next 0/2] net: Use SMP threads for backlog NAPI (or optional) Sebastian Andrzej Siewior
2023-09-29 16:20 ` [PATCH net-next 1/2] net: Use SMP threads for backlog NAPI Sebastian Andrzej Siewior
2023-09-29 16:20 ` [PATCH net-next 2/2] net: Allow to use " Sebastian Andrzej Siewior
2023-10-04 22:46 ` [PATCH net-next 0/2] net: Use SMP threads for backlog NAPI (or optional) Jakub Kicinski
2023-10-07 15:59 ` Sebastian Andrzej Siewior [this message]
2023-10-10 1:09 ` Jakub Kicinski
2023-10-16 9:53 ` Sebastian Andrzej Siewior
2023-10-16 14:17 ` Jakub Kicinski
2023-10-16 14:53 ` Sebastian Andrzej Siewior
2023-10-31 10:14 ` Sebastian Andrzej Siewior
2023-10-31 11:36 ` Wander Lairson Costa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231007155957.aPo0ImuG@linutronix.de \
--to=bigeasy@linutronix.de \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hawk@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).