From: Jakub Kicinski <kuba@kernel.org>
To: Przemek Kitszel <przemyslaw.kitszel@intel.com>
Cc: Andrew Lunn <andrew@lunn.ch>, <davem@davemloft.net>,
<netdev@vger.kernel.org>, <edumazet@google.com>,
<pabeni@redhat.com>, <jesse.brandeburg@intel.com>,
<sd@queasysnail.net>, <horms@verge.net.au>
Subject: Re: [RFC] docs: netdev: encourage reviewers
Date: Mon, 9 Oct 2023 09:13:10 -0700 [thread overview]
Message-ID: <20231009091310.7a6da97d@kernel.org> (raw)
In-Reply-To: <fad9a472-ae78-8672-6c93-58ddde1447d9@intel.com>
On Mon, 9 Oct 2023 17:13:45 +0200 Przemek Kitszel wrote:
> > Less experienced reviewers should avoid commenting exclusively on more
> > trivial / subjective matters like code formatting and process aspects
> > (e.g. missing subject tags).
>
> that should be taken for granted for experienced-but-new-to-community
> reviewer, but perhaps s/Less experienced/New/?
The set of Not new + Not experienced is not empty, right?
We want people to be cautious about posting such comments.
IOW what if people have been around for a while but aren't
very well versed in reviewing on netdev?
> > Sounds reasonable?
>
> yes!
>
> other thing, somewhat related:
> I believe that I personally (new to community, ~new to Intel) would do
> "best" for community trying to focus most on our outgoing patches (so
> "pre-review" wrt. to netdev, but less traffic here).
Herm, yes, definitely. It's a separate topic, tho, because the folks
at Intel who will read the FAQ are also those who understand the
problems with the internal process. The problem is not new, to move
the corporate processes we need metrics. I think.
> anyway,
> I feel encouraged here :)
Perfect :)
prev parent reply other threads:[~2023-10-09 16:13 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-06 16:30 [RFC] docs: netdev: encourage reviewers Jakub Kicinski
2023-10-06 16:38 ` Edward Cree
2023-10-06 16:42 ` Florian Fainelli
2023-10-06 16:59 ` Jiri Pirko
2023-10-06 18:41 ` Andrew Lunn
2023-10-06 18:57 ` Jakub Kicinski
2023-10-06 19:10 ` Jakub Kicinski
2023-10-06 19:36 ` Andrew Lunn
2023-10-06 21:21 ` Florian Fainelli
2023-10-09 15:13 ` Przemek Kitszel
2023-10-09 16:13 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231009091310.7a6da97d@kernel.org \
--to=kuba@kernel.org \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@verge.net.au \
--cc=jesse.brandeburg@intel.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=przemyslaw.kitszel@intel.com \
--cc=sd@queasysnail.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).