From: Jakub Kicinski <kuba@kernel.org>
To: Pedro Tammela <pctammela@mojatatu.com>
Cc: markovicbudimir@gmail.com, Christian Theune <ct@flyingcircus.io>,
stable@vger.kernel.org, netdev@vger.kernel.org,
Linux regressions mailing list <regressions@lists.linux.dev>,
davem@davemloft.net, edumazet@google.com, pabeni@redhat.com,
Jamal Hadi Salim <jhs@mojatatu.com>
Subject: Re: [REGRESSION] Userland interface breaks due to hard HFSC_FSC requirement
Date: Mon, 9 Oct 2023 17:28:49 -0700 [thread overview]
Message-ID: <20231009172849.00f4a6c5@kernel.org> (raw)
In-Reply-To: <da08ba06-e24c-d2c3-b9a0-8415a83ae791@mojatatu.com>
On Mon, 9 Oct 2023 12:31:57 -0300 Pedro Tammela wrote:
> > Herm, how did we get this far without CCing the author of the patch.
> > Adding Budimir.
> >
> > Pedro, Budimir, any idea what the original bug was? There isn't much
> > info in the commit message.
>
> We had a UAF with a very straight forward way to trigger it.
Any details?
> Setting 'rt' as a parent is incorrect and the man page is explicit about
> it as it doesn't make sense 'qdisc wise'. Being able to set it has
> always been wrong unfortunately...
Sure but unfortunately "we don't break backward compat" means
we can't really argue. It will take us more time to debate this
than to fix it (assuming we understand the initial problem).
Frankly one can even argue whether "exploitable by root / userns"
is more important than single user's init scripts breaking.
The "security" issues for root are dime a dozen.
next prev parent reply other threads:[~2023-10-10 0:28 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-06 8:37 [REGRESSION] Userland interface breaks due to hard HFSC_FSC requirement Christian Theune
2023-10-06 9:01 ` Linux regression tracking (Thorsten Leemhuis)
2023-10-06 9:07 ` Christian Theune
2023-10-06 9:16 ` Linux regression tracking (Thorsten Leemhuis)
2023-10-06 10:51 ` Christian Theune
2023-10-06 12:07 ` Bagas Sanjaya
2023-10-06 12:37 ` Christian Theune
2023-10-06 14:13 ` Bagas Sanjaya
2023-10-09 13:15 ` Christian Theune
2023-10-06 12:23 ` Florian Westphal
2023-10-06 18:51 ` Pedro Tammela
2023-10-06 22:12 ` Pedro Tammela
2023-10-07 4:10 ` Christian Theune
2023-10-09 15:06 ` Jakub Kicinski
2023-10-09 15:31 ` Pedro Tammela
2023-10-09 15:46 ` Christian Theune
2023-10-10 0:28 ` Jakub Kicinski [this message]
2023-10-10 15:02 ` Jamal Hadi Salim
2023-10-10 17:31 ` Christian Theune
2023-10-11 17:26 ` Jamal Hadi Salim
2023-10-10 18:26 ` Jakub Kicinski
2023-10-11 17:27 ` Jamal Hadi Salim
2023-10-11 18:11 ` Christian Theune
2023-11-01 19:05 ` Linux regression tracking #update (Thorsten Leemhuis)
2023-11-02 8:05 ` Linux regression tracking #update (Thorsten Leemhuis)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231009172849.00f4a6c5@kernel.org \
--to=kuba@kernel.org \
--cc=ct@flyingcircus.io \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jhs@mojatatu.com \
--cc=markovicbudimir@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pctammela@mojatatu.com \
--cc=regressions@lists.linux.dev \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).