* [patch net-next] netlink: specs: don't allow version to be specified for genetlink
@ 2023-10-09 15:49 Jiri Pirko
2023-10-10 1:26 ` Jakub Kicinski
0 siblings, 1 reply; 3+ messages in thread
From: Jiri Pirko @ 2023-10-09 15:49 UTC (permalink / raw)
To: netdev; +Cc: kuba, pabeni, davem, edumazet
From: Jiri Pirko <jiri@nvidia.com>
There is no good reason to specify the version for new protocols.
Forbid it in genetlink schema.
If the future proves me wrong, this restriction could be easily lifted.
Move the version definition in between legacy properties
in genetlink-legacy.
Suggested-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Jiri Pirko <jiri@nvidia.com>
---
Documentation/netlink/genetlink-legacy.yaml | 8 ++++----
Documentation/netlink/genetlink.yaml | 4 ----
2 files changed, 4 insertions(+), 8 deletions(-)
diff --git a/Documentation/netlink/genetlink-legacy.yaml b/Documentation/netlink/genetlink-legacy.yaml
index 12a0a045605d..6300222f6c84 100644
--- a/Documentation/netlink/genetlink-legacy.yaml
+++ b/Documentation/netlink/genetlink-legacy.yaml
@@ -26,10 +26,6 @@ properties:
type: string
doc:
type: string
- version:
- description: Generic Netlink family version. Default is 1.
- type: integer
- minimum: 1
protocol:
description: Schema compatibility level. Default is "genetlink".
enum: [ genetlink, genetlink-c, genetlink-legacy ] # Trim
@@ -53,6 +49,10 @@ properties:
Defines if the input policy in the kernel is global, per-operation, or split per operation type.
Default is split.
enum: [ split, per-op, global ]
+ version:
+ description: Generic Netlink family version. Default is 1.
+ type: integer
+ minimum: 1
# End genetlink-legacy
definitions:
diff --git a/Documentation/netlink/genetlink.yaml b/Documentation/netlink/genetlink.yaml
index 3d338c48bf21..f1427d7e3b4a 100644
--- a/Documentation/netlink/genetlink.yaml
+++ b/Documentation/netlink/genetlink.yaml
@@ -26,10 +26,6 @@ properties:
type: string
doc:
type: string
- version:
- description: Generic Netlink family version. Default is 1.
- type: integer
- minimum: 1
protocol:
description: Schema compatibility level. Default is "genetlink".
enum: [ genetlink ]
--
2.41.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [patch net-next] netlink: specs: don't allow version to be specified for genetlink
2023-10-09 15:49 [patch net-next] netlink: specs: don't allow version to be specified for genetlink Jiri Pirko
@ 2023-10-10 1:26 ` Jakub Kicinski
2023-10-10 7:26 ` Jiri Pirko
0 siblings, 1 reply; 3+ messages in thread
From: Jakub Kicinski @ 2023-10-10 1:26 UTC (permalink / raw)
To: Jiri Pirko; +Cc: netdev, pabeni, davem, edumazet
On Mon, 9 Oct 2023 17:49:07 +0200 Jiri Pirko wrote:
> Documentation/netlink/genetlink-legacy.yaml | 8 ++++----
> Documentation/netlink/genetlink.yaml | 4 ----
You missed genetlink-c
--
pw-bot: cr
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [patch net-next] netlink: specs: don't allow version to be specified for genetlink
2023-10-10 1:26 ` Jakub Kicinski
@ 2023-10-10 7:26 ` Jiri Pirko
0 siblings, 0 replies; 3+ messages in thread
From: Jiri Pirko @ 2023-10-10 7:26 UTC (permalink / raw)
To: Jakub Kicinski; +Cc: netdev, pabeni, davem, edumazet
Tue, Oct 10, 2023 at 03:26:44AM CEST, kuba@kernel.org wrote:
>On Mon, 9 Oct 2023 17:49:07 +0200 Jiri Pirko wrote:
>> Documentation/netlink/genetlink-legacy.yaml | 8 ++++----
>> Documentation/netlink/genetlink.yaml | 4 ----
>
>You missed genetlink-c
Ah, will fix.
>--
>pw-bot: cr
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-10-10 7:26 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-10-09 15:49 [patch net-next] netlink: specs: don't allow version to be specified for genetlink Jiri Pirko
2023-10-10 1:26 ` Jakub Kicinski
2023-10-10 7:26 ` Jiri Pirko
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).