netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jakub Kicinski <kuba@kernel.org>
To: Jiri Pirko <jiri@resnulli.us>
Cc: netdev@vger.kernel.org, pabeni@redhat.com, davem@davemloft.net,
	edumazet@google.com, gal@nvidia.com
Subject: Re: [patch net-next] devlink: don't take instance lock for nested handle put
Date: Tue, 10 Oct 2023 07:52:31 -0700	[thread overview]
Message-ID: <20231010075231.322ced83@kernel.org> (raw)
In-Reply-To: <ZST9yFTeeTuYD3RV@nanopsycho>

On Tue, 10 Oct 2023 09:31:20 +0200 Jiri Pirko wrote:
>> In Linux the PF is what controls the SFs, right?
>> Privileges, configuration/admin, resource control.
>> How can the parent disappear and children still exist.  
> 
> It's not like the PF instance disappears, the devlink port related to
> the SF is removed. Whan user does it, driver asks FW to shutdown the SF.
> That invokes FW flow which eventually leads to event delivered back to
> driver that removes the SF instance itself.

You understand what I'm saying tho, right?

If we can depend on the parent not disappearing before the child,
and the hierarchy is a DAG - the locking is much easier, because
parent can lock the child.

If it's only nVidia that put the control in hands of FW we shouldn't
complicate the core for y'all.

  reply	other threads:[~2023-10-10 14:52 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-03  7:43 [patch net-next] devlink: don't take instance lock for nested handle put Jiri Pirko
2023-10-06  1:30 ` Jakub Kicinski
2023-10-06  7:22   ` Jiri Pirko
2023-10-06 14:48     ` Jakub Kicinski
2023-10-06 17:07       ` Jiri Pirko
2023-10-06 22:14         ` Jakub Kicinski
2023-10-07 10:17           ` Jiri Pirko
2023-10-09 15:15             ` Jakub Kicinski
2023-10-09 15:37               ` Jiri Pirko
2023-10-09 16:31                 ` Jakub Kicinski
2023-10-10  7:31                   ` Jiri Pirko
2023-10-10 14:52                     ` Jakub Kicinski [this message]
2023-10-10 15:56                       ` Jiri Pirko
2023-10-10 18:16                         ` Jakub Kicinski
2023-10-11 13:34                           ` Jiri Pirko
2023-10-12  0:20                             ` Jakub Kicinski
2023-10-12  6:14                               ` Jiri Pirko
2023-10-13 15:39                                 ` Jakub Kicinski
2023-10-13 17:07                                   ` Jiri Pirko
2023-10-13 20:01                                     ` Jakub Kicinski
2023-10-15 11:12                                       ` Jiri Pirko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231010075231.322ced83@kernel.org \
    --to=kuba@kernel.org \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=gal@nvidia.com \
    --cc=jiri@resnulli.us \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).