From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1C098A34 for ; Tue, 10 Oct 2023 08:40:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="ivbCgZR6" Received: from relay3-d.mail.gandi.net (relay3-d.mail.gandi.net [217.70.183.195]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 41A8DB0; Tue, 10 Oct 2023 01:40:58 -0700 (PDT) Received: by mail.gandi.net (Postfix) with ESMTPSA id 566BA60015; Tue, 10 Oct 2023 08:40:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1696927256; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=wK4zIFPqfurxMkHf6VB6s+SlOkIyziORUxbFuzfwqTs=; b=ivbCgZR6obEsPfq2D5fylfPAo4F37C9TLOps9qaTjvpHeQZNGrpcx/HYSQiaFRa9xt82T1 +fCve+epducw5Df/xmMDoytnpOsW1SyDtog5ZgQIE/y7mLjBtVN22QRwn0DtScTGHhdEV0 kabf6eU7KDOEmVjBqMCmo0Mu0tTAZ0VKtb47JEGsBBmn4UV9ywQXjelp7hjKjTHVB5UJ9u 6isfpc/N5uNsqwujTpLdia7vf7e//NQP1hFO/AQfcWmBt9Jcg/okkB7l4r2znCnMkIa0kH j16fMxKy7NrsUcLBSCk5MeK7FZel5WYph7OMkEDszWSEvWpdekCxkf/dB6x0bA== Date: Tue, 10 Oct 2023 10:40:49 +0200 From: =?UTF-8?B?S8O2cnk=?= Maincent To: Florian Fainelli Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, Thomas Petazzoni , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Jonathan Corbet , Jay Vosburgh , Andy Gospodarek , Nicolas Ferre , Claudiu Beznea , Horatiu Vultur , UNGLinuxDriver@microchip.com, Broadcom internal kernel review list , Andrew Lunn , Heiner Kallweit , Russell King , Richard Cochran , Radu Pirea , Willem de Bruijn , Vladimir Oltean , Michael Walle , Jacob Keller , Maxime Chevallier Subject: Re: [PATCH net-next v5 09/16] netlink: specs: Introduce new netlink command to get current timestamp Message-ID: <20231010104049.1cbff3f8@kmaincent-XPS-13-7390> In-Reply-To: References: <20231009155138.86458-1-kory.maincent@bootlin.com> <20231009155138.86458-10-kory.maincent@bootlin.com> Organization: bootlin X-Mailer: Claws Mail 3.17.5 (GTK+ 2.24.32; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-GND-Sasl: kory.maincent@bootlin.com X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net On Mon, 9 Oct 2023 14:21:42 -0700 Florian Fainelli wrote: > On 10/9/23 08:51, K=C3=B6ry Maincent wrote: > > From: Kory Maincent > >=20 > > Add a new commands allowing to get the current time stamping on a > > netdevice's link. > >=20 > > Example usage : > > ./ynl/cli.py --spec netlink/specs/ethtool.yaml --no-schema --do ts-get \ > > --json '{"header":{"dev-name":"eth0"}}' > > {'header': {'dev-index': 3, 'dev-name': 'eth0'}, 'ts-layer': 1} > >=20 > > Signed-off-by: Kory Maincent =20 >=20 > This is small enough you could probably fold this patch into patch 8. I like having it separate. Indeed the ynl tool does not have a proper usage documentation. I took quite some times to me to understand how use it especially with bitset. Using the commit messages to add examples like that would have help me a lot in the process. I could also squash the example in the previous commit message but then it become more noisy. What do you think?