* [PATCH v1] Bug fix for issue found by kernel test robot
@ 2023-10-10 21:35 Anjali Kulkarni
2023-10-11 0:53 ` Jakub Kicinski
0 siblings, 1 reply; 3+ messages in thread
From: Anjali Kulkarni @ 2023-10-10 21:35 UTC (permalink / raw)
To: linux-kernel
Cc: davem, Liam.Howlett, netdev, oliver.sang, kuba, anjali.k.kulkarni
cn_netlink_send_mult() should be called with filter & filter_data only
for EXIT case. For all other events, filter & filter_data should be
NULL.
Signed-off-by: Anjali Kulkarni <anjali.k.kulkarni@oracle.com>
---
drivers/connector/cn_proc.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/connector/cn_proc.c b/drivers/connector/cn_proc.c
index 05d562e9c8b1..01e17f18d187 100644
--- a/drivers/connector/cn_proc.c
+++ b/drivers/connector/cn_proc.c
@@ -104,13 +104,13 @@ static inline void send_msg(struct cn_msg *msg)
if (filter_data[0] == PROC_EVENT_EXIT) {
filter_data[1] =
((struct proc_event *)msg->data)->event_data.exit.exit_code;
+ cn_netlink_send_mult(msg, msg->len, 0, CN_IDX_PROC, GFP_NOWAIT,
+ cn_filter, (void *)filter_data);
} else {
- filter_data[1] = 0;
+ cn_netlink_send_mult(msg, msg->len, 0, CN_IDX_PROC, GFP_NOWAIT,
+ NULL, NULL);
}
- cn_netlink_send_mult(msg, msg->len, 0, CN_IDX_PROC, GFP_NOWAIT,
- cn_filter, (void *)filter_data);
-
local_unlock(&local_event.lock);
}
--
2.42.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH v1] Bug fix for issue found by kernel test robot
2023-10-10 21:35 [PATCH v1] Bug fix for issue found by kernel test robot Anjali Kulkarni
@ 2023-10-11 0:53 ` Jakub Kicinski
2023-10-11 5:13 ` Anjali Kulkarni
0 siblings, 1 reply; 3+ messages in thread
From: Jakub Kicinski @ 2023-10-11 0:53 UTC (permalink / raw)
To: Anjali Kulkarni; +Cc: linux-kernel, davem, Liam.Howlett, netdev, oliver.sang
Thanks for the fix! Let's start with some basic process feedback :)
On Tue, 10 Oct 2023 14:35:49 -0700 Anjali Kulkarni wrote:
> Subject: [PATCH v1] Bug fix for issue found by kernel test robot
Subject needs to describe the issue (e.g. fix null-deref due to $xyz)
> cn_netlink_send_mult() should be called with filter & filter_data only
> for EXIT case. For all other events, filter & filter_data should be
> NULL.
We need (1) a Fixes tag pointing to the commit which added the bug
(2) appropriate Reported-by tag (see the syzbot report)
> Signed-off-by: Anjali Kulkarni <anjali.k.kulkarni@oracle.com>
--
pw-bot: cr
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v1] Bug fix for issue found by kernel test robot
2023-10-11 0:53 ` Jakub Kicinski
@ 2023-10-11 5:13 ` Anjali Kulkarni
0 siblings, 0 replies; 3+ messages in thread
From: Anjali Kulkarni @ 2023-10-11 5:13 UTC (permalink / raw)
To: Jakub Kicinski
Cc: linux-kernel@vger.kernel.org, davem@davemloft.net, Liam Howlett,
netdev@vger.kernel.org, oliver.sang@intel.com
> On Oct 10, 2023, at 5:53 PM, Jakub Kicinski <kuba@kernel.org> wrote:
>
> Thanks for the fix! Let's start with some basic process feedback :)
>
> On Tue, 10 Oct 2023 14:35:49 -0700 Anjali Kulkarni wrote:
>> Subject: [PATCH v1] Bug fix for issue found by kernel test robot
>
> Subject needs to describe the issue (e.g. fix null-deref due to $xyz)
Done.
>
>> cn_netlink_send_mult() should be called with filter & filter_data only
>> for EXIT case. For all other events, filter & filter_data should be
>> NULL.
>
> We need (1) a Fixes tag pointing to the commit which added the bug
> (2) appropriate Reported-by tag (see the syzbot report)
Done and sent out v2.
>
>> Signed-off-by: Anjali Kulkarni <anjali.k.kulkarni@oracle.com>
> --
> pw-bot: cr
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-10-11 5:13 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-10-10 21:35 [PATCH v1] Bug fix for issue found by kernel test robot Anjali Kulkarni
2023-10-11 0:53 ` Jakub Kicinski
2023-10-11 5:13 ` Anjali Kulkarni
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).