From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 92D2B15EA6 for ; Wed, 11 Oct 2023 06:12:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="sh55evse" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 55AD6C433C8; Wed, 11 Oct 2023 06:12:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1697004760; bh=sCKW1lulrN47qnO06iR1/PFLTCfQeGivHQvENFLnd44=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=sh55evse3eawotn5DPV6P3UPZnaDZNXkmV3FyJxFYsDVbqn2z/ujRcmRO8yuIjRkX P3wV8Iml+42CSfNWpOAJ1tVKPlQ67gMj1bKvPyhwPpll50Gm50i5+m4f1Edo4iJ4RD eaWA+xsxEuekEaCPdAwdQQtRwHY9kzM+9LXkGUOSudpVc4u+CiGwVt2Vrlo0Yw+SZP eqWw9+Oln6sqEfNd3Apa2Qe9M937XW3VZE8RM3C332fWUMXTSnCRgMe4sE7WXVNoYV oFGm7UwRm8ZNyJv2/CX+8Soz4p3QFuLHVYbvqQJCYRCZa9SslbJwQIlf6d2huRb+uA 46qPL4PkNSdMg== From: Saeed Mahameed To: "David S. Miller" , Jakub Kicinski , Paolo Abeni , Eric Dumazet Cc: Saeed Mahameed , netdev@vger.kernel.org, Tariq Toukan , Jinjie Ruan , Jacob Keller Subject: [net-next 08/15] net/mlx5: Use PTR_ERR_OR_ZERO() to simplify code Date: Tue, 10 Oct 2023 23:12:23 -0700 Message-ID: <20231011061230.11530-9-saeed@kernel.org> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20231011061230.11530-1-saeed@kernel.org> References: <20231011061230.11530-1-saeed@kernel.org> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Jinjie Ruan Return PTR_ERR_OR_ZERO() instead of return 0 or PTR_ERR() to simplify code. Signed-off-by: Jinjie Ruan Reviewed-by: Jacob Keller Signed-off-by: Saeed Mahameed --- drivers/net/ethernet/mellanox/mlx5/core/lag/port_sel.c | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/drivers/net/ethernet/mellanox/mlx5/core/lag/port_sel.c b/drivers/net/ethernet/mellanox/mlx5/core/lag/port_sel.c index 7d9bbb494d95..101b3bb90863 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/lag/port_sel.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/lag/port_sel.c @@ -507,10 +507,7 @@ static int mlx5_lag_create_ttc_table(struct mlx5_lag *ldev) mlx5_lag_set_outer_ttc_params(ldev, &ttc_params); port_sel->outer.ttc = mlx5_create_ttc_table(dev, &ttc_params); - if (IS_ERR(port_sel->outer.ttc)) - return PTR_ERR(port_sel->outer.ttc); - - return 0; + return PTR_ERR_OR_ZERO(port_sel->outer.ttc); } static int mlx5_lag_create_inner_ttc_table(struct mlx5_lag *ldev) @@ -521,10 +518,7 @@ static int mlx5_lag_create_inner_ttc_table(struct mlx5_lag *ldev) mlx5_lag_set_inner_ttc_params(ldev, &ttc_params); port_sel->inner.ttc = mlx5_create_inner_ttc_table(dev, &ttc_params); - if (IS_ERR(port_sel->inner.ttc)) - return PTR_ERR(port_sel->inner.ttc); - - return 0; + return PTR_ERR_OR_ZERO(port_sel->inner.ttc); } int mlx5_lag_port_sel_create(struct mlx5_lag *ldev, -- 2.41.0