Re: [PATCH net-next v5 0/5] dpll: add phase-offset and phase-adjust

Vadim Fedorenko
2023-10-13T11:13:08Z

On 11/10/2023 11:12, Arkadiusz Kubalewski wrote:
> Improve monitoring and control over dpll devices.
> Allow user to receive measurement of phase difference between signals
> on pin and dpll (phase-offset).
> Allow user to receive and control adjustable value of pin's signal
> phase (phase-adjust).
>
> v4->v5:
> - rebase series on top of net-next/main, fix conflict - remove redundant
> attribute type definition in subset definition
>
> v3->v4:
> - do not increase do version of uAPI header as it is not needed (v3 did
> not have this change)
> - fix spelling around commit messages, argument descriptions and docs
> - add missing extack errors on failure set callbacks for pin phase
> adjust and frequency
> - remove ice check if value is already set, now redundant as checked in
> the dpll subsystem
>
> v2->v3:
> - do not increase do version of uAPI header as it is not needed
>
> v1->v2:
> - improve handling for error case of requesting the phase adjust set
> - align handling for error case of frequency set request with the
> approach introduced for phase adjust
>
>
> Arkadiusz Kubalewski (5):
> dpll: docs: add support for pin signal phase offset/adjust
> dpll: spec: add support for pin-dpll signal phase offset/adjust
> dpll: netlink/core: add support for pin-dpll signal phase
> offset/adjust
> ice: dpll: implement phase related callbacks
> dpll: netlink/core: change pin frequency set behavior
>
> Documentation/driver-api/dpll.rst | 53 +++++-
> Documentation/netlink/specs/dpll.yaml | 30 +++
> drivers/dpll/dpll_netlink.c | 188 +++++++++++++++++-
> drivers/dpll/dpll_nl.c | 8 +-
> drivers/dpll/dpll_nl.h | 2 +-
> drivers/net/ethernet/intel/ice/ice_dpll.c | 220 +++++++++++++++++++++-
> drivers/net/ethernet/intel/ice/ice_dpll.h | 10 +-
> include/linux/dpll.h | 18 ++
> include/uapi/linux/dpll.h | 6 +
> 9 files changed, 517 insertions(+), 18 deletions(-)
>
For the series:
Acked-by: Vadim Fedorenko <vadim.fedorenko@linux.dev>

Thanks!