From: Arnd Bergmann <arnd@kernel.org>
To: Jakub Kicinski <kuba@kernel.org>
Cc: netdev@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-wireless@vger.kernel.org,
Johannes Berg <johannes@sipsolutions.net>,
linux-wpan@vger.kernel.org,
Michael Hennerich <michael.hennerich@analog.com>,
Paolo Abeni <pabeni@redhat.com>,
Eric Dumazet <edumazet@google.com>,
"David S . Miller" <davem@davemloft.net>,
Rodolfo Zitellini <rwz@xhero.org>,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
Arnd Bergmann <arnd@arndb.de>
Subject: [PATCH v2 10/10] net: remove ndo_do_ioctl handler
Date: Wed, 11 Oct 2023 16:02:25 +0200 [thread overview]
Message-ID: <20231011140225.253106-10-arnd@kernel.org> (raw)
In-Reply-To: <20231011140225.253106-1-arnd@kernel.org>
From: Arnd Bergmann <arnd@arndb.de>
All of the references to the callback pointer are gone, so remove the
pointer itself before we grow new references to it.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
Documentation/networking/netdevices.rst | 8 --------
include/linux/netdevice.h | 7 -------
2 files changed, 15 deletions(-)
diff --git a/Documentation/networking/netdevices.rst b/Documentation/networking/netdevices.rst
index 9e4cccb90b870..6f9b71c5d37b8 100644
--- a/Documentation/networking/netdevices.rst
+++ b/Documentation/networking/netdevices.rst
@@ -218,14 +218,6 @@ ndo_stop:
Context: process
Note: netif_running() is guaranteed false
-ndo_do_ioctl:
- Synchronization: rtnl_lock() semaphore.
- Context: process
-
- This is only called by network subsystems internally,
- not by user space calling ioctl as it was in before
- linux-5.14.
-
ndo_siocbond:
Synchronization: rtnl_lock() semaphore.
Context: process
diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h
index e070a4540fbaf..8d1cc8f195cb6 100644
--- a/include/linux/netdevice.h
+++ b/include/linux/netdevice.h
@@ -1121,11 +1121,6 @@ struct netdev_net_notifier {
* int (*ndo_validate_addr)(struct net_device *dev);
* Test if Media Access Control address is valid for the device.
*
- * int (*ndo_do_ioctl)(struct net_device *dev, struct ifreq *ifr, int cmd);
- * Old-style ioctl entry point. This is used internally by the
- * appletalk and ieee802154 subsystems but is no longer called by
- * the device ioctl handler.
- *
* int (*ndo_siocbond)(struct net_device *dev, struct ifreq *ifr, int cmd);
* Used by the bonding driver for its device specific ioctls:
* SIOCBONDENSLAVE, SIOCBONDRELEASE, SIOCBONDSETHWADDR, SIOCBONDCHANGEACTIVE,
@@ -1429,8 +1424,6 @@ struct net_device_ops {
int (*ndo_set_mac_address)(struct net_device *dev,
void *addr);
int (*ndo_validate_addr)(struct net_device *dev);
- int (*ndo_do_ioctl)(struct net_device *dev,
- struct ifreq *ifr, int cmd);
int (*ndo_eth_ioctl)(struct net_device *dev,
struct ifreq *ifr, int cmd);
int (*ndo_siocbond)(struct net_device *dev,
--
2.39.2
next prev parent reply other threads:[~2023-10-11 14:03 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-11 14:02 [PATCH v2 01/10] appletalk: make localtalk and ppp support conditional Arnd Bergmann
2023-10-11 14:02 ` [PATCH v2 02/10] ieee802154: avoid deprecated .ndo_do_ioctl callback Arnd Bergmann
2023-10-11 14:02 ` [PATCH v2 03/10] ethernet: sp7021: fix ioctl callback pointer Arnd Bergmann
2023-10-11 14:02 ` [PATCH v2 04/10] staging: ks7010: remove unused ioctl handler Arnd Bergmann
2023-10-11 14:02 ` [PATCH v2 05/10] staging: rtl8192: remove unused legacy ioctl handlers Arnd Bergmann
2023-10-11 14:02 ` [PATCH v2 06/10] staging: rtl8712: " Arnd Bergmann
2023-10-11 14:02 ` [PATCH v2 07/10] staging: rtl8723bs: remove dead code Arnd Bergmann
2023-10-11 14:02 ` [PATCH v2 08/10] wifi: atmel: remove unused ioctl function Arnd Bergmann
2023-10-14 6:42 ` Kalle Valo
2023-10-11 14:02 ` [PATCH v2 09/10] wifi: hostap: " Arnd Bergmann
2023-10-11 14:02 ` Arnd Bergmann [this message]
2023-10-11 15:04 ` [PATCH v2 01/10] appletalk: make localtalk and ppp support conditional Jiri Pirko
2023-10-11 15:57 ` Arnd Bergmann
2023-10-12 13:46 ` Jiri Pirko
2023-10-14 0:07 ` Jakub Kicinski
2023-10-14 5:00 ` Kalle Valo
2023-10-18 0:22 ` Jakub Kicinski
2023-10-18 0:22 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231011140225.253106-10-arnd@kernel.org \
--to=arnd@kernel.org \
--cc=arnd@arndb.de \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=johannes@sipsolutions.net \
--cc=kuba@kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linux-wpan@vger.kernel.org \
--cc=michael.hennerich@analog.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=rwz@xhero.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).