From: Jakub Kicinski <kuba@kernel.org>
To: Paul M Stillwell Jr <paul.m.stillwell.jr@intel.com>
Cc: Tony Nguyen <anthony.l.nguyen@intel.com>, <davem@davemloft.net>,
<pabeni@redhat.com>, <edumazet@google.com>,
<netdev@vger.kernel.org>, <jacob.e.keller@intel.com>,
<vaishnavi.tipireddy@intel.com>, <horms@kernel.org>,
<leon@kernel.org>,
Pucha Himasekhar Reddy <himasekharx.reddy.pucha@intel.com>
Subject: Re: [PATCH net-next v4 2/5] ice: configure FW logging
Date: Thu, 12 Oct 2023 16:40:33 -0700 [thread overview]
Message-ID: <20231012164033.1069fb4b@kernel.org> (raw)
In-Reply-To: <a810ade6-b847-28fa-6225-5f551a561940@intel.com>
On Wed, 11 Oct 2023 17:40:04 -0700 Paul M Stillwell Jr wrote:
> OK, so what if we changed the code to create a new debugfs file entry
> for each module and used the dentry for ther file to know what file is
> being written to. Then we would only need to parse the log level. Would
> that be acceptable?
Yes, even better!
> My confusion is around what makes the cmdline parsing harder to follow.
> Obviously for me it's easy :) so I am trying to understand your point of
> view.
Dunno how to explain it other than "took me more than 10min to
understand this code and I only had 10min" :) Reviewers have
their own angle when evaluation code which doesn't always align
with the author's..
next prev parent reply other threads:[~2023-10-12 23:40 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-05 17:01 [PATCH net-next v4 0/5][pull request] add v2 FW logging for ice driver Tony Nguyen
2023-10-05 17:01 ` [PATCH net-next v4 1/5] ice: remove FW logging code Tony Nguyen
2023-10-05 17:01 ` [PATCH net-next v4 2/5] ice: configure FW logging Tony Nguyen
2023-10-07 0:02 ` Jakub Kicinski
2023-10-10 23:26 ` Paul M Stillwell Jr
2023-10-11 2:01 ` Jakub Kicinski
2023-10-12 0:40 ` Paul M Stillwell Jr
2023-10-12 23:40 ` Jakub Kicinski [this message]
2023-10-17 20:38 ` Paul M Stillwell Jr
2023-10-05 17:01 ` [PATCH net-next v4 3/5] ice: enable " Tony Nguyen
2023-10-05 17:01 ` [PATCH net-next v4 4/5] ice: add ability to read FW log data and configure the number of log buffers Tony Nguyen
2023-10-05 17:01 ` [PATCH net-next v4 5/5] ice: add documentation for FW logging Tony Nguyen
2023-10-06 23:46 ` Jakub Kicinski
2023-10-10 23:00 ` Paul M Stillwell Jr
2023-10-11 1:18 ` Jakub Kicinski
2023-10-12 0:43 ` Paul M Stillwell Jr
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231012164033.1069fb4b@kernel.org \
--to=kuba@kernel.org \
--cc=anthony.l.nguyen@intel.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=himasekharx.reddy.pucha@intel.com \
--cc=horms@kernel.org \
--cc=jacob.e.keller@intel.com \
--cc=leon@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=paul.m.stillwell.jr@intel.com \
--cc=vaishnavi.tipireddy@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).