From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 40F773B29F for ; Thu, 12 Oct 2023 19:28:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="OT5gyaUE" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 07519C433C7; Thu, 12 Oct 2023 19:28:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1697138881; bh=sCKW1lulrN47qnO06iR1/PFLTCfQeGivHQvENFLnd44=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=OT5gyaUEQsH1irkSoB+SluhmCIh/Xk4ZbfOMZHO6Y7b1ArwHMuXfvOutPF8qxrWyF ykqwfJ2hKSCQf96bhCRcVWX4m45b/ak0nfWhBYFUSch0bYDWVTkmc+i/G/iOANQ3AS plSa1i8en6o0mzvWBx5bbZvU75kUfoESZOnHcDntU8wwr4enIDvPGVQBbGNUwsLa9i GdnFx8pd0C+392cPTC67SUMMuthajFPkpvV+A0z2tlUc3WYJ5ckbQRqapm0A0QST3B BnEUfRjt4KbIbi/4ETXd0mxOF0C2p71x1a54rc2FEoXZV29+3HpfK0rzNXZ0nBFaZz T6G/YTpc8YpRA== From: Saeed Mahameed To: "David S. Miller" , Jakub Kicinski , Paolo Abeni , Eric Dumazet Cc: Saeed Mahameed , netdev@vger.kernel.org, Tariq Toukan , Jinjie Ruan , Jacob Keller Subject: [net-next V2 08/15] net/mlx5: Use PTR_ERR_OR_ZERO() to simplify code Date: Thu, 12 Oct 2023 12:27:43 -0700 Message-ID: <20231012192750.124945-9-saeed@kernel.org> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20231012192750.124945-1-saeed@kernel.org> References: <20231012192750.124945-1-saeed@kernel.org> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Jinjie Ruan Return PTR_ERR_OR_ZERO() instead of return 0 or PTR_ERR() to simplify code. Signed-off-by: Jinjie Ruan Reviewed-by: Jacob Keller Signed-off-by: Saeed Mahameed --- drivers/net/ethernet/mellanox/mlx5/core/lag/port_sel.c | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/drivers/net/ethernet/mellanox/mlx5/core/lag/port_sel.c b/drivers/net/ethernet/mellanox/mlx5/core/lag/port_sel.c index 7d9bbb494d95..101b3bb90863 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/lag/port_sel.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/lag/port_sel.c @@ -507,10 +507,7 @@ static int mlx5_lag_create_ttc_table(struct mlx5_lag *ldev) mlx5_lag_set_outer_ttc_params(ldev, &ttc_params); port_sel->outer.ttc = mlx5_create_ttc_table(dev, &ttc_params); - if (IS_ERR(port_sel->outer.ttc)) - return PTR_ERR(port_sel->outer.ttc); - - return 0; + return PTR_ERR_OR_ZERO(port_sel->outer.ttc); } static int mlx5_lag_create_inner_ttc_table(struct mlx5_lag *ldev) @@ -521,10 +518,7 @@ static int mlx5_lag_create_inner_ttc_table(struct mlx5_lag *ldev) mlx5_lag_set_inner_ttc_params(ldev, &ttc_params); port_sel->inner.ttc = mlx5_create_inner_ttc_table(dev, &ttc_params); - if (IS_ERR(port_sel->inner.ttc)) - return PTR_ERR(port_sel->inner.ttc); - - return 0; + return PTR_ERR_OR_ZERO(port_sel->inner.ttc); } int mlx5_lag_port_sel_create(struct mlx5_lag *ldev, -- 2.41.0