From: Stephen Hemminger <stephen@networkplumber.org>
To: Vladimir Oltean <olteanv@gmail.com>
Cc: Florian Fainelli <florian.fainelli@broadcom.com>,
netdev@vger.kernel.org, Andrew Lunn <andrew@lunn.ch>,
Florian Fainelli <f.fainelli@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Broadcom internal kernel review list
<bcm-kernel-feedback-list@broadcom.com>,
"open list:ARM/Mediatek SoC support"
<linux-kernel@vger.kernel.org>,
"moderated list:ARM/Mediatek SoC support"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH net-next v2 2/2] net: dsa: Rename IFLA_DSA_MASTER to IFLA_DSA_CONDUIT
Date: Thu, 12 Oct 2023 19:30:54 -0700 [thread overview]
Message-ID: <20231012193054.4c6759fe@hermes.local> (raw)
In-Reply-To: <20231012231345.3thxxxhe7pxs5bib@skbuf>
On Fri, 13 Oct 2023 02:13:45 +0300
Vladimir Oltean <olteanv@gmail.com> wrote:
> > I don't know if it would be acceptable in the kernel UAPI but what
> > we did in DPDK for similar situation to cause warning on use of deprecated value.
> >
> > /**
> > * Macro to mark macros and defines scheduled for removal
> > */
> > #if defined(RTE_CC_GCC) || defined(RTE_CC_CLANG)
> > #define RTE_PRAGMA(x) _Pragma(#x)
> > #define RTE_PRAGMA_WARNING(w) RTE_PRAGMA(GCC warning #w)
> > #define RTE_DEPRECATED(x) RTE_PRAGMA_WARNING(#x is deprecated)
> > #else
> > #define RTE_DEPRECATED(x)
> > #endif
> >
> > ...
> > #define RTE_DEV_WHITELISTED \
> > RTE_DEPRECATED(RTE_DEV_WHITELISTED) RTE_DEV_ALLOWED
> > #define RTE_DEV_BLACKLISTED \
> > RTE_DEPRECATED(RTE_DEV_BLACKLISTED) RTE_DEV_BLOCKED
>
> What precedent exists in terms of intentionally breaking kernel headers?
> If none, would this create one?
It would cause warning, and most applications builds don't fail because of warning.
Kernel already has __diag_warn macro which is similar, but see no usages of it.
My comment was more of a "what if", probably not practical since it would just
fuel lots of angry user feedback.
next prev parent reply other threads:[~2023-10-13 2:30 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-11 22:20 [PATCH net-next v2 0/2] Switch DSA to inclusive terminology Florian Fainelli
2023-10-11 22:20 ` [PATCH net-next v2 1/2] net: dsa: Use conduit and user terms Florian Fainelli
2023-10-12 21:23 ` Andrew Lunn
2023-10-12 23:10 ` Vladimir Oltean
2023-10-13 2:27 ` Stephen Hemminger
2023-10-13 16:25 ` Stephen Hemminger
2023-10-13 16:27 ` Florian Fainelli
2023-10-23 7:12 ` Pavel Machek
2023-10-23 15:50 ` Florian Fainelli
2023-10-23 19:32 ` Vladimir Oltean
2023-10-11 22:20 ` [PATCH net-next v2 2/2] net: dsa: Rename IFLA_DSA_MASTER to IFLA_DSA_CONDUIT Florian Fainelli
2023-10-11 23:30 ` Stephen Hemminger
2023-10-12 23:13 ` Vladimir Oltean
2023-10-13 2:30 ` Stephen Hemminger [this message]
2023-10-11 23:22 ` [PATCH net-next v2 0/2] Switch DSA to inclusive terminology Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231012193054.4c6759fe@hermes.local \
--to=stephen@networkplumber.org \
--cc=andrew@lunn.ch \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=florian.fainelli@broadcom.com \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).