From: Ma Ke <make_ruc2021@163.com>
To: jmaloy@redhat.com, ying.xue@windriver.com, davem@davemloft.net,
edumazet@google.com, kuba@kernel.org, pabeni@redhat.com
Cc: netdev@vger.kernel.org, tipc-discussion@lists.sourceforge.net,
linux-kernel@vger.kernel.org, Ma Ke <make_ruc2021@163.com>
Subject: [PATCH] tipc: Fix uninit-value access in tipc_nl_node_get_link()
Date: Fri, 13 Oct 2023 15:04:08 +0800 [thread overview]
Message-ID: <20231013070408.1979343-1-make_ruc2021@163.com> (raw)
Names must be null-terminated strings. If a name which is not
null-terminated is passed through netlink, strstr() and similar
functions can cause buffer overrun. This patch fixes this issue
by returning -EINVAL if a non-null-terminated name is passed.
Signed-off-by: Ma Ke <make_ruc2021@163.com>
---
net/tipc/node.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/net/tipc/node.c b/net/tipc/node.c
index 3105abe97bb9..a02bcd7e07d3 100644
--- a/net/tipc/node.c
+++ b/net/tipc/node.c
@@ -2519,6 +2519,9 @@ int tipc_nl_node_get_link(struct sk_buff *skb, struct genl_info *info)
return -EINVAL;
name = nla_data(attrs[TIPC_NLA_LINK_NAME]);
+ if (name[strnlen(name,
+ nla_len(attrs[TIPC_NLA_LINK_NAME]))] != '\0')
+ return -EINVAL;
msg.skb = nlmsg_new(NLMSG_GOODSIZE, GFP_KERNEL);
if (!msg.skb)
--
2.37.2
next reply other threads:[~2023-10-13 7:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-13 7:04 Ma Ke [this message]
2023-10-13 8:56 ` [PATCH] tipc: Fix uninit-value access in tipc_nl_node_get_link() Vadim Fedorenko
2023-10-13 9:20 ` Florian Westphal
2023-10-14 0:17 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231013070408.1979343-1-make_ruc2021@163.com \
--to=make_ruc2021@163.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jmaloy@redhat.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=tipc-discussion@lists.sourceforge.net \
--cc=ying.xue@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).