From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BF4EE13FF7 for ; Fri, 13 Oct 2023 12:01:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="rlUxoZCO" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 17FB2C433C7; Fri, 13 Oct 2023 12:01:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1697198468; bh=3oSV4wrD/VI++CPjF8EIFb1o1M+cd24rSplIjiYIWZQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=rlUxoZCOMvp9g/HsQZN5dp8ZWPZx6QOhRnZ98IJmckIaJoLyfYZNIzzG3vpb2dJzY DXWomoi7mo5Mu/CFkD0OPChiEzmBmdwwSv4HQiTCN4Omw4D7TLUtroJFMgPj1xtjHg 1cPG9g+YTJoLfLrrcZyw88Ul4XtmcohDdqBUNXiAfP6CL1YJnVRce8HNU0zIOkFaP4 M86iRH6QEqMSHSEw9rGN/0REWO6UJnrCTmSRHNq89QdHYwo3aeJzMwSrev/816v8YS sjMsSHJfRDkFY+gNdPNapi5HNuPnsTSeXtgRVZNDHaEz4Qy8j7ZkFCoGQNcPEKF0yW pzr5DK/7k5Crw== Date: Fri, 13 Oct 2023 14:01:05 +0200 From: Simon Horman To: Anjali Kulkarni Cc: linux-kernel@vger.kernel.org, davem@davemloft.net, Liam.Howlett@oracle.com, netdev@vger.kernel.org, oliver.sang@intel.com Subject: Re: [PATCH v2] Fix NULL pointer deref due to filtering on fork Message-ID: <20231013120105.GH29570@kernel.org> References: <20231011051225.3674436-1-anjali.k.kulkarni@oracle.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231011051225.3674436-1-anjali.k.kulkarni@oracle.com> On Tue, Oct 10, 2023 at 10:12:25PM -0700, Anjali Kulkarni wrote: > cn_netlink_send_mult() should be called with filter & filter_data only > for EXIT case. For all other events, filter & filter_data should be > NULL. > > Fixes: 2aa1f7a1f47c ("connector/cn_proc: Add filtering to fix some bugs") > Reported-by: kernel test robot > Closes: https://urldefense.com/v3/__https://lore.kernel.org/oe-lkp/202309201456.84c19e27-oliver.sang@intel.com__;!!ACWV5N9M2RV99hQ!PgqlHq_nOe_KlyKkB9Mm_S8QstTJvicjuENwskatuuQK05KPuFw-KvRZeOH8iuEAMjRhkxEMPKJJnLcaT8zrPf9aqNs$ For the record, this got a bit mangled. I believe it should be: Closes: https://lore.kernel.org/oe-lkp/202309201456.84c19e27-oliver.sang@intel.com/ Also, there is probably no need to resend because of this, but no blank line here, please. > Signed-off-by: Anjali Kulkarni > --- > drivers/connector/cn_proc.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/connector/cn_proc.c b/drivers/connector/cn_proc.c > index 05d562e9c8b1..01e17f18d187 100644 > --- a/drivers/connector/cn_proc.c > +++ b/drivers/connector/cn_proc.c > @@ -104,13 +104,13 @@ static inline void send_msg(struct cn_msg *msg) > if (filter_data[0] == PROC_EVENT_EXIT) { > filter_data[1] = > ((struct proc_event *)msg->data)->event_data.exit.exit_code; > + cn_netlink_send_mult(msg, msg->len, 0, CN_IDX_PROC, GFP_NOWAIT, > + cn_filter, (void *)filter_data); > } else { > - filter_data[1] = 0; > + cn_netlink_send_mult(msg, msg->len, 0, CN_IDX_PROC, GFP_NOWAIT, > + NULL, NULL); > } > > - cn_netlink_send_mult(msg, msg->len, 0, CN_IDX_PROC, GFP_NOWAIT, > - cn_filter, (void *)filter_data); > - I am wondering if you considered making cn_filter slightly smarter. It seems it already understands not to do very much for PROC_EVENT_ALL. > local_unlock(&local_event.lock); > } > > -- > 2.42.0 > >