From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 562E17E; Sat, 14 Oct 2023 00:07:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="UdBr2wcD" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 744BCC433C7; Sat, 14 Oct 2023 00:07:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1697242054; bh=6kpMwlfSNasU9AQMtLitDygCjCpDKwjI+adsPbqa9OA=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=UdBr2wcD9YbkjCo7SyrOU7C2P7cOL79UAKLiM1BqeppHoumCz76G9EbxX7WR2a7v0 Y60I+lH6kFJnJziGqDlxqaLZNQaM/awAaSidgcGYR+9q83BJ2QxSZEZjTjIuk348Pi ffyBwFqzUhY++R8GyWNdABQ2xssKv/CC5BMpYdyuVHIv/3fh2UddcuGDzzePUzM0Zj ZFZNP9zKbvbYP8evuVMaLBq3Uhtdj7X0PFkWqqfqRdG+UIQQ5Ycc52CB8UiFnpBAQL Xh9FykSlCiuWrvhF9vOqoSKQIaFP4aVwTfh1v/CEpEBtX9JaFGG1pCzHzRUPMxahBz kL3fZdQ9ejoyw== Date: Fri, 13 Oct 2023 17:07:32 -0700 From: Jakub Kicinski To: "Johannes Berg" , Kalle Valo Cc: "Arnd Bergmann" , "Jiri Pirko" , "Arnd Bergmann" , Netdev , "Greg Kroah-Hartman" , linux-wireless@vger.kernel.org, linux-wpan@vger.kernel.org, "Michael Hennerich" , "Paolo Abeni" , "Eric Dumazet" , "David S . Miller" , "Rodolfo Zitellini" , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 01/10] appletalk: make localtalk and ppp support conditional Message-ID: <20231013170732.587afd86@kernel.org> In-Reply-To: <82527b7f-4509-4a59-a9cf-2df47e6e1a7c@app.fastmail.com> References: <20231011140225.253106-1-arnd@kernel.org> <82527b7f-4509-4a59-a9cf-2df47e6e1a7c@app.fastmail.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Wed, 11 Oct 2023 17:57:38 +0200 Arnd Bergmann wrote: > The .ndo_do_ioctl() netdev operation used to be how one communicates > with a network driver from userspace, but since my previous cleanup [1], > it is purely internal to the kernel. > > Removing the cops appletalk/localtalk driver made me revisit the > missing pieces from that older series, removing all the unused > implementations in wireless drivers as well as the two kernel-internal > callers in the ieee802154 and appletalk stacks. > > One ethernet driver was already merged in the meantime that should > have used .ndo_eth_ioctl instead of .ndo_do_ioctl, so fix that as well. > With the complete removal, any future drivers making this mistake > cause build failures that are easier to spot. > > [1] https://lore.kernel.org/netdev/20201106221743.3271965-1-arnd@kernel.org/ Kalle, Johannes, do these apply for you? I'm getting a small conflict on patch 8 and bigger one on patch 9. If this applies for you maybe you can take it and flush out wireless-next soon after?