From: Simon Horman <horms@kernel.org>
To: Aaron Conole <aconole@redhat.com>
Cc: netdev@vger.kernel.org, dev@openvswitch.org,
linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org,
Pravin B Shelar <pshelar@ovn.org>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Adrian Moreno <amorenoz@redhat.com>,
Eelco Chaudron <echaudro@redhat.com>,
shuah@kernel.org
Subject: Re: [PATCH net v2 0/4] selftests: openvswitch: Minor fixes for some systems
Date: Fri, 13 Oct 2023 22:06:26 +0200 [thread overview]
Message-ID: <20231013200626.GS29570@kernel.org> (raw)
In-Reply-To: <20231011194939.704565-1-aconole@redhat.com>
On Wed, Oct 11, 2023 at 03:49:35PM -0400, Aaron Conole wrote:
> A number of corner cases were caught when trying to run the selftests on
> older systems. Missed skip conditions, some error cases, and outdated
> python setups would all report failures but the issue would actually be
> related to some other condition rather than the selftest suite.
>
> Address these individual cases.
>
> Aaron Conole (4):
> selftests: openvswitch: Add version check for pyroute2
> selftests: openvswitch: Catch cases where the tests are killed
> selftests: openvswitch: Skip drop testing on older kernels
> selftests: openvswitch: Fix the ct_tuple for v4
>
> .../selftests/net/openvswitch/openvswitch.sh | 21 +++++++-
> .../selftests/net/openvswitch/ovs-dpctl.py | 48 ++++++++++++++++++-
> 2 files changed, 66 insertions(+), 3 deletions(-)
Thanks Aaron,
this looks like a good incremental improvement to me.
For series,
Reviewed-by: Simon Horman <horms@kernel.org>
next prev parent reply other threads:[~2023-10-13 20:06 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-11 19:49 [PATCH net v2 0/4] selftests: openvswitch: Minor fixes for some systems Aaron Conole
2023-10-11 19:49 ` [PATCH net v2 1/4] selftests: openvswitch: Add version check for pyroute2 Aaron Conole
2023-10-11 19:49 ` [PATCH net v2 2/4] selftests: openvswitch: Catch cases where the tests are killed Aaron Conole
2023-10-11 19:49 ` [PATCH net v2 3/4] selftests: openvswitch: Skip drop testing on older kernels Aaron Conole
2023-10-11 19:49 ` [PATCH net v2 4/4] selftests: openvswitch: Fix the ct_tuple for v4 Aaron Conole
2023-10-13 20:06 ` Simon Horman [this message]
2023-10-15 19:10 ` [PATCH net v2 0/4] selftests: openvswitch: Minor fixes for some systems patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231013200626.GS29570@kernel.org \
--to=horms@kernel.org \
--cc=aconole@redhat.com \
--cc=amorenoz@redhat.com \
--cc=davem@davemloft.net \
--cc=dev@openvswitch.org \
--cc=echaudro@redhat.com \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pshelar@ovn.org \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).