From: Saeed Mahameed <saeed@kernel.org>
To: "David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Eric Dumazet <edumazet@google.com>
Cc: Saeed Mahameed <saeedm@nvidia.com>,
netdev@vger.kernel.org, Tariq Toukan <tariqt@nvidia.com>,
Jinjie Ruan <ruanjinjie@huawei.com>,
Jacob Keller <jacob.e.keller@intel.com>
Subject: [net-next V3 08/15] net/mlx5: Use PTR_ERR_OR_ZERO() to simplify code
Date: Sat, 14 Oct 2023 10:19:01 -0700 [thread overview]
Message-ID: <20231014171908.290428-9-saeed@kernel.org> (raw)
In-Reply-To: <20231014171908.290428-1-saeed@kernel.org>
From: Jinjie Ruan <ruanjinjie@huawei.com>
Return PTR_ERR_OR_ZERO() instead of return 0 or PTR_ERR() to
simplify code.
Signed-off-by: Jinjie Ruan <ruanjinjie@huawei.com>
Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>
Signed-off-by: Saeed Mahameed <saeedm@nvidia.com>
---
drivers/net/ethernet/mellanox/mlx5/core/lag/port_sel.c | 10 ++--------
1 file changed, 2 insertions(+), 8 deletions(-)
diff --git a/drivers/net/ethernet/mellanox/mlx5/core/lag/port_sel.c b/drivers/net/ethernet/mellanox/mlx5/core/lag/port_sel.c
index 7d9bbb494d95..101b3bb90863 100644
--- a/drivers/net/ethernet/mellanox/mlx5/core/lag/port_sel.c
+++ b/drivers/net/ethernet/mellanox/mlx5/core/lag/port_sel.c
@@ -507,10 +507,7 @@ static int mlx5_lag_create_ttc_table(struct mlx5_lag *ldev)
mlx5_lag_set_outer_ttc_params(ldev, &ttc_params);
port_sel->outer.ttc = mlx5_create_ttc_table(dev, &ttc_params);
- if (IS_ERR(port_sel->outer.ttc))
- return PTR_ERR(port_sel->outer.ttc);
-
- return 0;
+ return PTR_ERR_OR_ZERO(port_sel->outer.ttc);
}
static int mlx5_lag_create_inner_ttc_table(struct mlx5_lag *ldev)
@@ -521,10 +518,7 @@ static int mlx5_lag_create_inner_ttc_table(struct mlx5_lag *ldev)
mlx5_lag_set_inner_ttc_params(ldev, &ttc_params);
port_sel->inner.ttc = mlx5_create_inner_ttc_table(dev, &ttc_params);
- if (IS_ERR(port_sel->inner.ttc))
- return PTR_ERR(port_sel->inner.ttc);
-
- return 0;
+ return PTR_ERR_OR_ZERO(port_sel->inner.ttc);
}
int mlx5_lag_port_sel_create(struct mlx5_lag *ldev,
--
2.41.0
next prev parent reply other threads:[~2023-10-14 17:19 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-14 17:18 [pull request][net-next V3 00/15] mlx5 updates 2023-10-10 Saeed Mahameed
2023-10-14 17:18 ` [net-next V3 01/15] net/mlx5: Parallelize vhca event handling Saeed Mahameed
2023-10-18 1:40 ` patchwork-bot+netdevbpf
2023-10-14 17:18 ` [net-next V3 02/15] net/mlx5: Redesign SF active work to remove table_lock Saeed Mahameed
2023-10-14 17:18 ` [net-next V3 03/15] net/mlx5: Avoid false positive lockdep warning by adding lock_class_key Saeed Mahameed
2023-10-14 17:18 ` [net-next V3 04/15] net/mlx5: Refactor LAG peer device lookout bus logic to mlx5 devcom Saeed Mahameed
2023-10-14 17:18 ` [net-next V3 05/15] net/mlx5: Replace global mlx5_intf_lock with HCA devcom component lock Saeed Mahameed
2023-10-14 17:18 ` [net-next V3 06/15] net/mlx5: Remove unused declaration Saeed Mahameed
2023-10-14 17:19 ` [net-next V3 07/15] net/mlx5: fix config name in Kconfig parameter documentation Saeed Mahameed
2023-10-14 17:19 ` Saeed Mahameed [this message]
2023-10-14 17:19 ` [net-next V3 09/15] net/mlx5e: Use PTR_ERR_OR_ZERO() to simplify code Saeed Mahameed
2023-10-14 17:19 ` [net-next V3 10/15] net/mlx5e: Refactor rx_res_init() and rx_res_free() APIs Saeed Mahameed
2023-10-14 17:19 ` [net-next V3 11/15] net/mlx5e: Refactor mlx5e_rss_set_rxfh() and mlx5e_rss_get_rxfh() Saeed Mahameed
2023-10-14 17:19 ` [net-next V3 12/15] net/mlx5e: Refactor mlx5e_rss_init() and mlx5e_rss_free() API's Saeed Mahameed
2023-10-14 17:19 ` [net-next V3 13/15] net/mlx5e: Preparations for supporting larger number of channels Saeed Mahameed
2023-10-14 17:19 ` [net-next V3 14/15] net/mlx5e: Increase max supported channels number to 256 Saeed Mahameed
2023-10-14 17:19 ` [net-next V3 15/15] net/mlx5e: Allow IPsec soft/hard limits in bytes Saeed Mahameed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231014171908.290428-9-saeed@kernel.org \
--to=saeed@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jacob.e.keller@intel.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=ruanjinjie@huawei.com \
--cc=saeedm@nvidia.com \
--cc=tariqt@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).