From: Florian Westphal <fw@strlen.de>
To: Victor Nogueira <victor@mojatatu.com>
Cc: jhs@mojatatu.com, daniel@iogearbox.net, xiyou.wangcong@gmail.com,
jiri@resnulli.us, davem@davemloft.net, edumazet@google.com,
kuba@kernel.org, pabeni@redhat.com, paulb@nvidia.com,
bpf@vger.kernel.org, mleitner@redhat.com, martin.lau@linux.dev,
dcaratti@redhat.com, netdev@vger.kernel.org, kernel@mojatatu.com
Subject: Re: [PATCH RFC net-next v2 1/1] net: sched: Disambiguate verdict from return code
Date: Sat, 14 Oct 2023 21:00:51 +0200 [thread overview]
Message-ID: <20231014190051.GA23755@breakpoint.cc> (raw)
In-Reply-To: <20231014180921.833820-1-victor@mojatatu.com>
Victor Nogueira <victor@mojatatu.com> wrote:
> + FN(TC_ALLOC_SKB_EXT) \
I think that SKB_DROP_REASON_NOMEM is fine for this, adding
a new drop reason for every type of object alloction failure
doesn't help.
The other ones are things that do point at tc specific config problems
so no objections there.
> ext = tc_skb_ext_alloc(skb);
> - if (WARN_ON_ONCE(!ext))
> + if (WARN_ON_ONCE(!ext)) {
> + u32 drop_reason = SKB_TC_ALLOC_SKB_EXT;
> +
> + tcf_set_drop_reason(res, drop_reason);
Unrelated to your patch, but I think this WARN_ON makes no sense.
There is nothing the user or a developer could do about that GFP_ATOMIC failure.
Also I see this patch gets rid of some, but not all, CONFIG_NET_CLS_ACT ifdefs.
The changelog should mention why.
Otherwise this LGTM.
next prev parent reply other threads:[~2023-10-14 19:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-14 18:09 [PATCH RFC net-next v2 1/1] net: sched: Disambiguate verdict from return code Victor Nogueira
2023-10-14 19:00 ` Florian Westphal [this message]
2023-10-16 14:01 ` Davide Caratti
2023-10-16 14:11 ` Jamal Hadi Salim
2023-10-16 16:04 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231014190051.GA23755@breakpoint.cc \
--to=fw@strlen.de \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=dcaratti@redhat.com \
--cc=edumazet@google.com \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=kernel@mojatatu.com \
--cc=kuba@kernel.org \
--cc=martin.lau@linux.dev \
--cc=mleitner@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=paulb@nvidia.com \
--cc=victor@mojatatu.com \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).