From: "Michael S. Tsirkin" <mst@redhat.com>
To: Heng Qi <hengqi@linux.alibaba.com>
Cc: Jakub Kicinski <kuba@kernel.org>,
Jason Wang <jasowang@redhat.com>,
netdev@vger.kernel.org,
virtualization@lists.linux-foundation.org,
Xuan Zhuo <xuanzhuo@linux.alibaba.com>,
Eric Dumazet <edumazet@google.com>,
"David S. Miller" <davem@davemloft.net>,
Paolo Abeni <pabeni@redhat.com>,
Jesper Dangaard Brouer <hawk@kernel.org>,
John Fastabend <john.fastabend@gmail.com>,
Alexei Starovoitov <ast@kernel.org>,
Simon Horman <horms@kernel.org>,
"Liu, Yujie" <yujie.liu@intel.com>
Subject: Re: [PATCH net-next 2/5] virtio-net: separate rx/tx coalescing moderation cmds
Date: Mon, 16 Oct 2023 03:51:22 -0400 [thread overview]
Message-ID: <20231016035034-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <06d90cc8-ccc0-4b2f-ad42-2db4a6fb229f@linux.alibaba.com>
On Mon, Oct 16, 2023 at 03:45:38PM +0800, Heng Qi wrote:
>
>
> 在 2023/10/14 上午9:11, Jakub Kicinski 写道:
> > On Thu, 12 Oct 2023 15:44:06 +0800 Heng Qi wrote:
> > > +
> > > +static int virtnet_send_rx_notf_coal_cmds(struct virtnet_info *vi,
> > > + struct ethtool_coalesce *ec)
> > > +{
> > > + struct scatterlist sgs_rx;
> > > +
> > ../drivers/net/virtio_net.c: In function ‘virtnet_send_rx_notf_coal_cmds’:
> > ../drivers/net/virtio_net.c:3306:14: error: ‘i’ undeclared (first use in this function); did you mean ‘vi’?
> > 3306 | for (i = 0; i < vi->max_queue_pairs; i++) {
> > | ^
> > | vi
>
> Will fix in the next version.
>
> Thanks!
OK, however pls do test individual patches as well as the whole
patchset.
--
MST
next prev parent reply other threads:[~2023-10-16 7:51 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-12 7:44 [PATCH net-next 0/5] virtio-net: support dynamic coalescing moderation Heng Qi
2023-10-12 7:44 ` [PATCH net-next 1/5] virtio-net: returns whether napi is complete Heng Qi
2023-10-25 2:43 ` Jason Wang
2023-10-12 7:44 ` [PATCH net-next 2/5] virtio-net: separate rx/tx coalescing moderation cmds Heng Qi
2023-10-14 1:11 ` Jakub Kicinski
2023-10-16 7:45 ` Heng Qi
2023-10-16 7:51 ` Michael S. Tsirkin [this message]
2023-10-12 7:44 ` [PATCH net-next 3/5] virtio-net: extract virtqueue coalescig cmd for reuse Heng Qi
2023-10-25 3:03 ` Jason Wang
2023-10-12 7:44 ` [PATCH net-next 4/5] virtio-net: support rx netdim Heng Qi
2023-10-25 3:34 ` Jason Wang
2023-11-01 10:55 ` Heng Qi
2023-11-02 4:31 ` Jason Wang
2023-11-02 4:46 ` Heng Qi
2023-10-12 7:44 ` [PATCH net-next 5/5] virtio-net: support tx netdim Heng Qi
2023-10-25 3:35 ` Jason Wang
2023-10-25 5:50 ` Michael S. Tsirkin
2023-10-12 8:29 ` [PATCH net-next 0/5] virtio-net: support dynamic coalescing moderation Jason Wang
2023-10-13 1:53 ` Jason Wang
2023-10-16 7:35 ` Heng Qi
2023-10-24 12:02 ` Heng Qi
2023-10-25 1:18 ` Jason Wang
2023-10-25 5:53 ` Michael S. Tsirkin
2023-11-01 11:03 ` Heng Qi
2023-11-02 4:33 ` Jason Wang
2023-11-02 4:47 ` Heng Qi
2023-11-01 9:38 ` Heng Qi
2023-11-02 4:34 ` Jason Wang
2023-11-02 4:51 ` Heng Qi
2023-11-02 4:53 ` Heng Qi
2023-10-25 5:49 ` Michael S. Tsirkin
2023-11-01 9:40 ` Heng Qi
2023-11-01 10:44 ` Michael S. Tsirkin
2023-11-01 10:57 ` Heng Qi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231016035034-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=ast@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hawk@kernel.org \
--cc=hengqi@linux.alibaba.com \
--cc=horms@kernel.org \
--cc=jasowang@redhat.com \
--cc=john.fastabend@gmail.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=virtualization@lists.linux-foundation.org \
--cc=xuanzhuo@linux.alibaba.com \
--cc=yujie.liu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).