From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 866F7266CD; Mon, 16 Oct 2023 12:03:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="fag5K/ov" Received: from mail-ed1-x535.google.com (mail-ed1-x535.google.com [IPv6:2a00:1450:4864:20::535]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D486DDC; Mon, 16 Oct 2023 05:03:19 -0700 (PDT) Received: by mail-ed1-x535.google.com with SMTP id 4fb4d7f45d1cf-522bd411679so7426338a12.0; Mon, 16 Oct 2023 05:03:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1697457798; x=1698062598; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=RjUacR5/LdrXMtLaYoD++xnhGSnh9YIzXLKxqzrbi9Q=; b=fag5K/ovN5h+1h2jpiZlqecxXSC17FzVe69BAxPGLTBOWdlzOChlgwSqICo5995xJC r7QPgGZfNko6Geh2dNgu+PepZOmVZINLJrzF9Q+3cKn6xV+uaVRIrdSApTWXhl5+A0oO +ryt9qKgHnW/9uHNPhoukFks7MBx9bt1bwX5cn/AUuu0x+s94wwJfvJ3p+5c2gjlFKiu 02QiT5yrWxbxranddajXfRhClQVyxrEso3oIcyXX2O2AZwigwtr2/ZxckJpIMxXdA0sW xTBRxbQ1soEqZJysrI6Jfc/TB+DLmrp7VlrvhxQojSDP+HBVV8w2iCLhJbi8NVuArTVu 99EQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697457798; x=1698062598; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=RjUacR5/LdrXMtLaYoD++xnhGSnh9YIzXLKxqzrbi9Q=; b=bP38Y1RXMZnRPRxnzD7GUWz/UNkxojiX4aFcdiSAn021wF21DgPwMjvhUTDN1TwD4a 5u95kZ2qQ+A4H56NcHMdHPKMjpxBMRT5zsDWYR2PfGc91g6n4wQOJO1WjZRR6vEmN1Uz rA/yLK2ixqiP2pH40m8BnAg3dKIW8JkBcJDfMqtEk3hzeTyXfIdnVEnlTucVWxB+qbdP /pmN2UX/ay4Wyu1eXLfblPXJkG2qN6sF69FXMaI+NARwM6bQL6BbvxrPo9UJnyA0Uwf+ Fs9tzq+G7G8lMlN+icyhTKp7NIX/4F3KXkz/cd6MDqx5A28nP5tCSGJa+Vm+BO54cJPP d6pA== X-Gm-Message-State: AOJu0YyQOLZJH4+LcSVaXFZBGBp/bFComHMEV1IbA58fEu00eUXCz0SS oK18nOkFhlRPjdGGn6bQ82U= X-Google-Smtp-Source: AGHT+IG/Ko9BhtySUyAd73/dS5Li/71YVHmIG1DDzxo3qY5wbPYtiM5W2gXqGTMCeKeyASkqvM/FLA== X-Received: by 2002:a05:6402:42c7:b0:53e:bc08:3bb2 with SMTP id i7-20020a05640242c700b0053ebc083bb2mr3070790edc.16.1697457798241; Mon, 16 Oct 2023 05:03:18 -0700 (PDT) Received: from skbuf ([188.26.57.160]) by smtp.gmail.com with ESMTPSA id v3-20020a056402174300b0053e3839fc79sm5028824edx.96.2023.10.16.05.03.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Oct 2023 05:03:18 -0700 (PDT) Date: Mon, 16 Oct 2023 15:03:15 +0300 From: Vladimir Oltean To: Linus Walleij Cc: Andrew Lunn , Gregory Clement , Sebastian Hesselbarth , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Russell King , Florian Fainelli , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Christian Marangi , linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH net-next v3 3/6] dt-bindings: net: mvusb: Fix up DSA example Message-ID: <20231016120315.nhiz6ukzmtdnx7vc@skbuf> References: <20231016-marvell-88e6152-wan-led-v3-0-38cd449dfb15@linaro.org> <20231016-marvell-88e6152-wan-led-v3-3-38cd449dfb15@linaro.org> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231016-marvell-88e6152-wan-led-v3-3-38cd449dfb15@linaro.org> X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net On Mon, Oct 16, 2023 at 11:12:56AM +0200, Linus Walleij wrote: > When adding a proper schema for the Marvell mx88e6xxx switch, > the scripts start complaining about this embedded example: > > dtschema/dtc warnings/errors: > net/marvell,mvusb.example.dtb: switch@0: ports: '#address-cells' > is a required property > from schema $id: http://devicetree.org/schemas/net/dsa/marvell,mv88e6xxx.yaml# > net/marvell,mvusb.example.dtb: switch@0: ports: '#size-cells' > is a required property > from schema $id: http://devicetree.org/schemas/net/dsa/marvell,mv88e6xxx.yaml# > > Fix this up by extending the example. > > Signed-off-by: Linus Walleij > --- > Documentation/devicetree/bindings/net/marvell,mvusb.yaml | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/Documentation/devicetree/bindings/net/marvell,mvusb.yaml b/Documentation/devicetree/bindings/net/marvell,mvusb.yaml > index 3a3325168048..ee677cf7df4e 100644 > --- a/Documentation/devicetree/bindings/net/marvell,mvusb.yaml > +++ b/Documentation/devicetree/bindings/net/marvell,mvusb.yaml > @@ -56,6 +56,12 @@ examples: > > ports { > /* Port definitions */ > + #address-cells = <1>; > + #size-cells = <0>; > + > + port@0 { > + reg = <0>; > + }; Could you just skip defining any port, and just leave the /* Port definitions */ comment at the end (after the newly added #address-cells and #size-cells)? This example is more about the USB adapter, not about the switch. > }; > > mdio { > > -- > 2.34.1 >