From: Ido Schimmel <idosch@nvidia.com>
To: <netdev@vger.kernel.org>, <bridge@lists.linux-foundation.org>
Cc: <davem@davemloft.net>, <kuba@kernel.org>, <edumazet@google.com>,
<pabeni@redhat.com>, <roopa@nvidia.com>, <razor@blackwall.org>,
<mlxsw@nvidia.com>, Ido Schimmel <idosch@nvidia.com>
Subject: [PATCH net-next 01/13] bridge: mcast: Dump MDB entries even when snooping is disabled
Date: Mon, 16 Oct 2023 16:12:47 +0300 [thread overview]
Message-ID: <20231016131259.3302298-2-idosch@nvidia.com> (raw)
In-Reply-To: <20231016131259.3302298-1-idosch@nvidia.com>
Currently, the bridge driver does not dump MDB entries when multicast
snooping is disabled although the entries are present in the kernel:
# bridge mdb add dev br0 port swp1 grp 239.1.1.1 permanent
# bridge mdb show dev br0
dev br0 port swp1 grp 239.1.1.1 permanent
dev br0 port br0 grp ff02::6a temp
dev br0 port br0 grp ff02::1:ff9d:e61b temp
# ip link set dev br0 type bridge mcast_snooping 0
# bridge mdb show dev br0
# ip link set dev br0 type bridge mcast_snooping 1
# bridge mdb show dev br0
dev br0 port swp1 grp 239.1.1.1 permanent
dev br0 port br0 grp ff02::6a temp
dev br0 port br0 grp ff02::1:ff9d:e61b temp
This behavior differs from other netlink dump interfaces that dump
entries regardless if they are used or not. For example, VLANs are
dumped even when VLAN filtering is disabled:
# ip link set dev br0 type bridge vlan_filtering 0
# bridge vlan show dev swp1
port vlan-id
swp1 1 PVID Egress Untagged
Remove the check and always dump MDB entries:
# bridge mdb add dev br0 port swp1 grp 239.1.1.1 permanent
# bridge mdb show dev br0
dev br0 port swp1 grp 239.1.1.1 permanent
dev br0 port br0 grp ff02::6a temp
dev br0 port br0 grp ff02::1:ffeb:1a4d temp
# ip link set dev br0 type bridge mcast_snooping 0
# bridge mdb show dev br0
dev br0 port swp1 grp 239.1.1.1 permanent
dev br0 port br0 grp ff02::6a temp
dev br0 port br0 grp ff02::1:ffeb:1a4d temp
# ip link set dev br0 type bridge mcast_snooping 1
# bridge mdb show dev br0
dev br0 port swp1 grp 239.1.1.1 permanent
dev br0 port br0 grp ff02::6a temp
dev br0 port br0 grp ff02::1:ffeb:1a4d temp
Signed-off-by: Ido Schimmel <idosch@nvidia.com>
---
net/bridge/br_mdb.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/net/bridge/br_mdb.c b/net/bridge/br_mdb.c
index 7305f5f8215c..fb58bb1b60e8 100644
--- a/net/bridge/br_mdb.c
+++ b/net/bridge/br_mdb.c
@@ -323,9 +323,6 @@ static int br_mdb_fill_info(struct sk_buff *skb, struct netlink_callback *cb,
struct net_bridge_mdb_entry *mp;
struct nlattr *nest, *nest2;
- if (!br_opt_get(br, BROPT_MULTICAST_ENABLED))
- return 0;
-
nest = nla_nest_start_noflag(skb, MDBA_MDB);
if (nest == NULL)
return -EMSGSIZE;
--
2.40.1
next prev parent reply other threads:[~2023-10-16 13:14 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-16 13:12 [PATCH net-next 00/13] Add MDB get support Ido Schimmel
2023-10-16 13:12 ` Ido Schimmel [this message]
2023-10-17 9:04 ` [PATCH net-next 01/13] bridge: mcast: Dump MDB entries even when snooping is disabled Nikolay Aleksandrov
2023-10-16 13:12 ` [PATCH net-next 02/13] bridge: mcast: Account for missing attributes Ido Schimmel
2023-10-17 9:05 ` Nikolay Aleksandrov
2023-10-16 13:12 ` [PATCH net-next 03/13] bridge: mcast: Factor out a helper for PG entry size calculation Ido Schimmel
2023-10-17 9:05 ` Nikolay Aleksandrov
2023-10-16 13:12 ` [PATCH net-next 04/13] bridge: mcast: Rename MDB entry get function Ido Schimmel
2023-10-17 9:06 ` Nikolay Aleksandrov
2023-10-16 13:12 ` [PATCH net-next 05/13] vxlan: mdb: Adjust function arguments Ido Schimmel
2023-10-17 9:06 ` Nikolay Aleksandrov
2023-10-16 13:12 ` [PATCH net-next 06/13] vxlan: mdb: Factor out a helper for remote entry size calculation Ido Schimmel
2023-10-17 9:06 ` Nikolay Aleksandrov
2023-10-16 13:12 ` [PATCH net-next 07/13] bridge: add MDB get uAPI attributes Ido Schimmel
2023-10-17 9:08 ` Nikolay Aleksandrov
2023-10-17 10:58 ` Ido Schimmel
2023-10-16 13:12 ` [PATCH net-next 08/13] net: Add MDB get device operation Ido Schimmel
2023-10-17 9:08 ` Nikolay Aleksandrov
2023-10-16 13:12 ` [PATCH net-next 09/13] bridge: mcast: Add MDB get support Ido Schimmel
2023-10-17 9:24 ` Nikolay Aleksandrov
2023-10-17 11:03 ` Ido Schimmel
2023-10-17 12:53 ` Nikolay Aleksandrov
2023-10-16 13:12 ` [PATCH net-next 10/13] vxlan: mdb: " Ido Schimmel
2023-10-17 9:28 ` Nikolay Aleksandrov
2023-10-16 13:12 ` [PATCH net-next 11/13] rtnetlink: " Ido Schimmel
2023-10-17 9:29 ` Nikolay Aleksandrov
2023-10-16 13:12 ` [PATCH net-next 12/13] selftests: bridge_mdb: Use MDB get instead of dump Ido Schimmel
2023-10-17 9:29 ` Nikolay Aleksandrov
2023-10-16 13:12 ` [PATCH net-next 13/13] selftests: vxlan_mdb: " Ido Schimmel
2023-10-17 9:30 ` Nikolay Aleksandrov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231016131259.3302298-2-idosch@nvidia.com \
--to=idosch@nvidia.com \
--cc=bridge@lists.linux-foundation.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=mlxsw@nvidia.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=razor@blackwall.org \
--cc=roopa@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).