From: Ido Schimmel <idosch@nvidia.com>
To: <netdev@vger.kernel.org>, <bridge@lists.linux-foundation.org>
Cc: <davem@davemloft.net>, <kuba@kernel.org>, <edumazet@google.com>,
<pabeni@redhat.com>, <roopa@nvidia.com>, <razor@blackwall.org>,
<mlxsw@nvidia.com>, Ido Schimmel <idosch@nvidia.com>
Subject: [PATCH net-next 03/13] bridge: mcast: Factor out a helper for PG entry size calculation
Date: Mon, 16 Oct 2023 16:12:49 +0300 [thread overview]
Message-ID: <20231016131259.3302298-4-idosch@nvidia.com> (raw)
In-Reply-To: <20231016131259.3302298-1-idosch@nvidia.com>
Currently, netlink notifications are sent for individual port group
entries and not for the entire MDB entry itself.
Subsequent patches are going to add MDB get support which will require
the bridge driver to reply with an entire MDB entry.
Therefore, as a preparation, factor out an helper to calculate the size
of an individual port group entry. When determining the size of the
reply this helper will be invoked for each port group entry in the MDB
entry.
No functional changes intended.
Signed-off-by: Ido Schimmel <idosch@nvidia.com>
---
net/bridge/br_mdb.c | 20 +++++++++++++-------
1 file changed, 13 insertions(+), 7 deletions(-)
diff --git a/net/bridge/br_mdb.c b/net/bridge/br_mdb.c
index 08de94bffc12..42983f6a0abd 100644
--- a/net/bridge/br_mdb.c
+++ b/net/bridge/br_mdb.c
@@ -450,18 +450,13 @@ static int nlmsg_populate_mdb_fill(struct sk_buff *skb,
return -EMSGSIZE;
}
-static size_t rtnl_mdb_nlmsg_size(struct net_bridge_port_group *pg)
+static size_t rtnl_mdb_nlmsg_pg_size(const struct net_bridge_port_group *pg)
{
struct net_bridge_group_src *ent;
size_t nlmsg_size, addr_size = 0;
- nlmsg_size = NLMSG_ALIGN(sizeof(struct br_port_msg)) +
- /* MDBA_MDB */
- nla_total_size(0) +
- /* MDBA_MDB_ENTRY */
- nla_total_size(0) +
/* MDBA_MDB_ENTRY_INFO */
- nla_total_size(sizeof(struct br_mdb_entry)) +
+ nlmsg_size = nla_total_size(sizeof(struct br_mdb_entry)) +
/* MDBA_MDB_EATTR_TIMER */
nla_total_size(sizeof(u32));
@@ -511,6 +506,17 @@ static size_t rtnl_mdb_nlmsg_size(struct net_bridge_port_group *pg)
return nlmsg_size;
}
+static size_t rtnl_mdb_nlmsg_size(const struct net_bridge_port_group *pg)
+{
+ return NLMSG_ALIGN(sizeof(struct br_port_msg)) +
+ /* MDBA_MDB */
+ nla_total_size(0) +
+ /* MDBA_MDB_ENTRY */
+ nla_total_size(0) +
+ /* Port group entry */
+ rtnl_mdb_nlmsg_pg_size(pg);
+}
+
void br_mdb_notify(struct net_device *dev,
struct net_bridge_mdb_entry *mp,
struct net_bridge_port_group *pg,
--
2.40.1
next prev parent reply other threads:[~2023-10-16 13:14 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-16 13:12 [PATCH net-next 00/13] Add MDB get support Ido Schimmel
2023-10-16 13:12 ` [PATCH net-next 01/13] bridge: mcast: Dump MDB entries even when snooping is disabled Ido Schimmel
2023-10-17 9:04 ` Nikolay Aleksandrov
2023-10-16 13:12 ` [PATCH net-next 02/13] bridge: mcast: Account for missing attributes Ido Schimmel
2023-10-17 9:05 ` Nikolay Aleksandrov
2023-10-16 13:12 ` Ido Schimmel [this message]
2023-10-17 9:05 ` [PATCH net-next 03/13] bridge: mcast: Factor out a helper for PG entry size calculation Nikolay Aleksandrov
2023-10-16 13:12 ` [PATCH net-next 04/13] bridge: mcast: Rename MDB entry get function Ido Schimmel
2023-10-17 9:06 ` Nikolay Aleksandrov
2023-10-16 13:12 ` [PATCH net-next 05/13] vxlan: mdb: Adjust function arguments Ido Schimmel
2023-10-17 9:06 ` Nikolay Aleksandrov
2023-10-16 13:12 ` [PATCH net-next 06/13] vxlan: mdb: Factor out a helper for remote entry size calculation Ido Schimmel
2023-10-17 9:06 ` Nikolay Aleksandrov
2023-10-16 13:12 ` [PATCH net-next 07/13] bridge: add MDB get uAPI attributes Ido Schimmel
2023-10-17 9:08 ` Nikolay Aleksandrov
2023-10-17 10:58 ` Ido Schimmel
2023-10-16 13:12 ` [PATCH net-next 08/13] net: Add MDB get device operation Ido Schimmel
2023-10-17 9:08 ` Nikolay Aleksandrov
2023-10-16 13:12 ` [PATCH net-next 09/13] bridge: mcast: Add MDB get support Ido Schimmel
2023-10-17 9:24 ` Nikolay Aleksandrov
2023-10-17 11:03 ` Ido Schimmel
2023-10-17 12:53 ` Nikolay Aleksandrov
2023-10-16 13:12 ` [PATCH net-next 10/13] vxlan: mdb: " Ido Schimmel
2023-10-17 9:28 ` Nikolay Aleksandrov
2023-10-16 13:12 ` [PATCH net-next 11/13] rtnetlink: " Ido Schimmel
2023-10-17 9:29 ` Nikolay Aleksandrov
2023-10-16 13:12 ` [PATCH net-next 12/13] selftests: bridge_mdb: Use MDB get instead of dump Ido Schimmel
2023-10-17 9:29 ` Nikolay Aleksandrov
2023-10-16 13:12 ` [PATCH net-next 13/13] selftests: vxlan_mdb: " Ido Schimmel
2023-10-17 9:30 ` Nikolay Aleksandrov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231016131259.3302298-4-idosch@nvidia.com \
--to=idosch@nvidia.com \
--cc=bridge@lists.linux-foundation.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=mlxsw@nvidia.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=razor@blackwall.org \
--cc=roopa@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).