From: Marc Kleine-Budde <mkl@pengutronix.de>
To: Jakub Kicinski <kuba@kernel.org>
Cc: Johannes Zink <j.zink@pengutronix.de>,
kernel@pengutronix.de, linux-kernel@vger.kernel.org,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
netdev@vger.kernel.org,
Richard Cochran <richardcochran@gmail.com>,
Kurt Kanzenbach <kurt@linutronix.de>,
Alexandre Torgue <alexandre.torgue@foss.st.com>,
linux-stm32@st-md-mailman.stormreply.com,
Eric Dumazet <edumazet@google.com>,
Jose Abreu <joabreu@synopsys.com>,
Simon Horman <horms@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
"David S. Miller" <davem@davemloft.net>,
linux-arm-kernel@lists.infradead.org,
patchwork-jzi@pengutronix.de
Subject: Re: [PATCH net-next 2/5] net: stmmac: fix PPS capture input index
Date: Tue, 17 Oct 2023 22:27:41 +0200 [thread overview]
Message-ID: <20231017-transfer-refurbish-5cfaf12a524c-mkl@pengutronix.de> (raw)
In-Reply-To: <20231017082618.4558ad06@kernel.org>
[-- Attachment #1: Type: text/plain, Size: 1692 bytes --]
On 17.10.2023 08:26:18, Jakub Kicinski wrote:
> On Tue, 17 Oct 2023 11:12:53 +0200 Johannes Zink wrote:
> > > If it is a bug fix then it should probably be targeted at 'net',
> > > creating a dependency for the remainder of this series.
> > >
> > > On the other hand, if it is not a bug fix then perhaps it is best to
> > > update the subject and drop the Fixes tag.
> >
> > I added the fixes-Tag in order to make code archeology easier, but as it may
> > trigger picks to stable branches (which is not required imho), I have no
> > objections to dropping it for a v2.
>
> Would be good to clarify what impact on device operation the problem
> has. How would end user notice the problem?
> Does it mean snapshots were always or never enabled, previously?
On all dwmac devices not covered by dwmac-intel.c (INTEL 10/100/1000
Ethernet PCI driver), PPS capture can be requested from user-space, but
is not enabled in HW. There is no error message or other feedback to the
user space. The user space will not get any PPS events.
As this change also affects the Intel driver, and we don't have any
hardware to test, I think it's better that this goes via net-next to
give it a bit more time of testing.
> Note that if you submit this fix for net today it will still make it
> to -rc7 and net-next by tomorrow, so no major delay. We merge the trees
> on Thursday, usually.
regards,
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Embedded Linux | https://www.pengutronix.de |
Vertretung Nürnberg | Phone: +49-5121-206917-129 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-9 |
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2023-10-17 20:28 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-12 9:02 [PATCH net-next 0/5] net: stmmac: fix PPS input indexing Johannes Zink
2023-10-12 9:02 ` [PATCH net-next 1/5] net: stmmac: simplify debug message on stmmac_enable() Johannes Zink
2023-10-12 9:02 ` [PATCH net-next 2/5] net: stmmac: fix PPS capture input index Johannes Zink
2023-10-14 14:44 ` Simon Horman
2023-10-17 9:12 ` Johannes Zink
2023-10-17 15:26 ` Jakub Kicinski
2023-10-17 20:27 ` Marc Kleine-Budde [this message]
2023-10-17 23:50 ` Jakub Kicinski
2023-10-18 5:55 ` Johannes Zink
2023-10-12 9:02 ` [PATCH net-next 3/5] net: stmmac: intel: remove unnecessary field struct plat_stmmacenet_data::ext_snapshot_num Johannes Zink
2023-10-12 9:02 ` [PATCH net-next 4/5] net: stmmac: ptp: stmmac_enable(): move change of plat->flags into mutex Johannes Zink
2023-10-12 9:02 ` [PATCH net-next 5/5] net: stmmac: do not silently change auxiliary snapshot capture channel Johannes Zink
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231017-transfer-refurbish-5cfaf12a524c-mkl@pengutronix.de \
--to=mkl@pengutronix.de \
--cc=alexandre.torgue@foss.st.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=j.zink@pengutronix.de \
--cc=joabreu@synopsys.com \
--cc=kernel@pengutronix.de \
--cc=kuba@kernel.org \
--cc=kurt@linutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=patchwork-jzi@pengutronix.de \
--cc=richardcochran@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).