From: Simon Horman <horms@kernel.org>
To: Davide Caratti <dcaratti@redhat.com>
Cc: Matthieu Baerts <matttbe@kernel.org>,
mptcp@lists.linux.dev, "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Mat Martineau <martineau@kernel.org>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next 4/6] uapi: mptcp: use header file generated from YAML spec
Date: Tue, 17 Oct 2023 10:58:13 +0200 [thread overview]
Message-ID: <20231017085813.GP1751252@kernel.org> (raw)
In-Reply-To: <CAKa-r6uYbhF3zZrDaZdCE1fo4A8WF0MHNGmLS21fh11WcSfqOg@mail.gmail.com>
On Sat, Oct 14, 2023 at 01:37:43PM +0200, Davide Caratti wrote:
> hello Simon, thanks for reading!
>
> On Fri, Oct 13, 2023 at 7:30 PM Simon Horman <horms@kernel.org> wrote:
> >
> > On Tue, Oct 10, 2023 at 09:21:45PM +0200, Matthieu Baerts wrote:
> > > From: Davide Caratti <dcaratti@redhat.com>
> > >
> > > generated with:
> > >
> > > $ ./tools/net/ynl/ynl-gen-c.py --mode uapi \
> > > > --spec Documentation/netlink/specs/mptcp.yaml \
> > > > --header -o include/uapi/linux/mptcp_pm.h
>
> [...]
>
> > > +/**
> > > + * enum mptcp_event_type
> >
> > Hi Davide and Matthieu,
> >
> > I understand that is autogenerated.
> > But it is missing an entry here for @MPTCP_EVENT_UNSPEC.
> > Can that be addressed somehow?
>
> probably it just needs
> doc: unused event
>
> in the YAML file, I will add it and regenerate the uAPI header
Thanks!
next prev parent reply other threads:[~2023-10-17 8:58 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-10 19:21 [PATCH net-next 0/6] mptcp: convert Netlink code to use YAML spec Matthieu Baerts
2023-10-10 19:21 ` [PATCH net-next 1/6] tools: ynl: add uns-admin-perm to genetlink legacy Matthieu Baerts
2023-10-10 19:21 ` [PATCH net-next 2/6] net: mptcp: convert netlink from small_ops to ops Matthieu Baerts
2023-10-10 19:21 ` [PATCH net-next 3/6] Documentation: netlink: add a YAML spec for mptcp Matthieu Baerts
2023-10-11 1:08 ` Jakub Kicinski
2023-10-11 10:13 ` Davide Caratti
2023-10-11 16:22 ` Jakub Kicinski
2023-10-10 19:21 ` [PATCH net-next 4/6] uapi: mptcp: use header file generated from YAML spec Matthieu Baerts
2023-10-13 17:28 ` Simon Horman
2023-10-14 11:37 ` Davide Caratti
2023-10-17 8:58 ` Simon Horman [this message]
2023-10-10 19:21 ` [PATCH net-next 5/6] net: mptcp: rename netlink handlers to mptcp_pm_nl_<blah>_{doit,dumpit} Matthieu Baerts
2023-10-10 19:21 ` [PATCH net-next 6/6] net: mptcp: use policy generated by YAML spec Matthieu Baerts
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231017085813.GP1751252@kernel.org \
--to=horms@kernel.org \
--cc=davem@davemloft.net \
--cc=dcaratti@redhat.com \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martineau@kernel.org \
--cc=matttbe@kernel.org \
--cc=mptcp@lists.linux.dev \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).