* [PATCH net] net: phy: bcm7xxx: Add missing 16nm EPHY statistics
@ 2023-10-16 18:44 Florian Fainelli
2023-10-16 18:51 ` Andrew Lunn
2023-10-17 19:45 ` Simon Horman
0 siblings, 2 replies; 4+ messages in thread
From: Florian Fainelli @ 2023-10-16 18:44 UTC (permalink / raw)
To: netdev
Cc: Florian Fainelli, Justin Chen,
Broadcom internal kernel review list, Andrew Lunn,
Heiner Kallweit, Russell King, David S. Miller, Eric Dumazet,
Jakub Kicinski, Paolo Abeni,
open list:BROADCOM ETHERNET PHY DRIVERS, open list
[-- Attachment #1: Type: text/plain, Size: 1074 bytes --]
The .probe() function would allocate the necessary space and ensure that
the library call sizes the nunber of statistics but the callbacks
necessary to fetch the name and values were not wired up.
Reported-by: Justin Chen <justin.chen@broadcom.com>
Fixes: 1b89b3dce34c ("net: phy: bcm7xxx: Add EPHY entry for 72165")
Signed-off-by: Florian Fainelli <florian.fainelli@broadcom.com>
---
drivers/net/phy/bcm7xxx.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/net/phy/bcm7xxx.c b/drivers/net/phy/bcm7xxx.c
index 8478b081c058..97638ba7ae85 100644
--- a/drivers/net/phy/bcm7xxx.c
+++ b/drivers/net/phy/bcm7xxx.c
@@ -894,6 +894,9 @@ static int bcm7xxx_28nm_probe(struct phy_device *phydev)
.name = _name, \
/* PHY_BASIC_FEATURES */ \
.flags = PHY_IS_INTERNAL, \
+ .get_sset_count = bcm_phy_get_sset_count, \
+ .get_strings = bcm_phy_get_strings, \
+ .get_stats = bcm7xxx_28nm_get_phy_stats, \
.probe = bcm7xxx_28nm_probe, \
.config_init = bcm7xxx_16nm_ephy_config_init, \
.config_aneg = genphy_config_aneg, \
--
2.34.1
[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4221 bytes --]
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH net] net: phy: bcm7xxx: Add missing 16nm EPHY statistics
2023-10-16 18:44 [PATCH net] net: phy: bcm7xxx: Add missing 16nm EPHY statistics Florian Fainelli
@ 2023-10-16 18:51 ` Andrew Lunn
2023-10-17 19:45 ` Simon Horman
1 sibling, 0 replies; 4+ messages in thread
From: Andrew Lunn @ 2023-10-16 18:51 UTC (permalink / raw)
To: Florian Fainelli
Cc: netdev, Justin Chen, Broadcom internal kernel review list,
Heiner Kallweit, Russell King, David S. Miller, Eric Dumazet,
Jakub Kicinski, Paolo Abeni,
open list:BROADCOM ETHERNET PHY DRIVERS, open list
On Mon, Oct 16, 2023 at 11:44:28AM -0700, Florian Fainelli wrote:
> The .probe() function would allocate the necessary space and ensure that
> the library call sizes the nunber of statistics but the callbacks
> necessary to fetch the name and values were not wired up.
>
> Reported-by: Justin Chen <justin.chen@broadcom.com>
> Fixes: 1b89b3dce34c ("net: phy: bcm7xxx: Add EPHY entry for 72165")
> Signed-off-by: Florian Fainelli <florian.fainelli@broadcom.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH net] net: phy: bcm7xxx: Add missing 16nm EPHY statistics
2023-10-16 18:44 [PATCH net] net: phy: bcm7xxx: Add missing 16nm EPHY statistics Florian Fainelli
2023-10-16 18:51 ` Andrew Lunn
@ 2023-10-17 19:45 ` Simon Horman
2023-10-17 20:37 ` Florian Fainelli
1 sibling, 1 reply; 4+ messages in thread
From: Simon Horman @ 2023-10-17 19:45 UTC (permalink / raw)
To: Florian Fainelli
Cc: netdev, Justin Chen, Broadcom internal kernel review list,
Andrew Lunn, Heiner Kallweit, Russell King, David S. Miller,
Eric Dumazet, Jakub Kicinski, Paolo Abeni,
open list:BROADCOM ETHERNET PHY DRIVERS, open list
On Mon, Oct 16, 2023 at 11:44:28AM -0700, Florian Fainelli wrote:
> The .probe() function would allocate the necessary space and ensure that
> the library call sizes the nunber of statistics but the callbacks
> necessary to fetch the name and values were not wired up.
>
> Reported-by: Justin Chen <justin.chen@broadcom.com>
> Fixes: 1b89b3dce34c ("net: phy: bcm7xxx: Add EPHY entry for 72165")
Should the fixes tag be as follows?
Fixes: f68d08c437f9 ("net: phy: bcm7xxx: Add EPHY entry for 72165")
> Signed-off-by: Florian Fainelli <florian.fainelli@broadcom.com>
...
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH net] net: phy: bcm7xxx: Add missing 16nm EPHY statistics
2023-10-17 19:45 ` Simon Horman
@ 2023-10-17 20:37 ` Florian Fainelli
0 siblings, 0 replies; 4+ messages in thread
From: Florian Fainelli @ 2023-10-17 20:37 UTC (permalink / raw)
To: Simon Horman, Florian Fainelli
Cc: netdev, Justin Chen, Broadcom internal kernel review list,
Andrew Lunn, Heiner Kallweit, Russell King, David S. Miller,
Eric Dumazet, Jakub Kicinski, Paolo Abeni,
open list:BROADCOM ETHERNET PHY DRIVERS, open list
On 10/17/23 12:45, Simon Horman wrote:
> On Mon, Oct 16, 2023 at 11:44:28AM -0700, Florian Fainelli wrote:
>> The .probe() function would allocate the necessary space and ensure that
>> the library call sizes the nunber of statistics but the callbacks
>> necessary to fetch the name and values were not wired up.
>>
>> Reported-by: Justin Chen <justin.chen@broadcom.com>
>> Fixes: 1b89b3dce34c ("net: phy: bcm7xxx: Add EPHY entry for 72165")
>
> Should the fixes tag be as follows?
>
> Fixes: f68d08c437f9 ("net: phy: bcm7xxx: Add EPHY entry for 72165")
Yes it should, it looks like 1b89b3dce34c was from our downstream tree.
Let me re-submit with the correct Fixes tag then, thanks Simon!
--
Florian
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-10-17 20:37 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-10-16 18:44 [PATCH net] net: phy: bcm7xxx: Add missing 16nm EPHY statistics Florian Fainelli
2023-10-16 18:51 ` Andrew Lunn
2023-10-17 19:45 ` Simon Horman
2023-10-17 20:37 ` Florian Fainelli
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).