From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6348D8C0C for ; Wed, 18 Oct 2023 08:44:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="ZMblYaWx" Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3E48EF7 for ; Wed, 18 Oct 2023 01:44:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1697618675; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=k/0liIrEL7QSkgX7qVs1vHsvuoJgLIVTs8YD9K4UGPw=; b=ZMblYaWxJcLQiBBcwIk5cRT0qOfLS2SrncYlvxqo8l0RBkpnn54gdpnx0bky7ViVY/H0Qc FgVLSff151BJDpUGKofpoLqsrLD5DjC8zE8GGWCAxKLKufJoyp1dJJAamjsVRuBZnCAwA+ uo16hU/0g8GRBlyhHkLyKOM94j2Kivo= Received: from mail-oi1-f198.google.com (mail-oi1-f198.google.com [209.85.167.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-586-Dfhse9FBPLW8fmsaYx2kcQ-1; Wed, 18 Oct 2023 04:44:34 -0400 X-MC-Unique: Dfhse9FBPLW8fmsaYx2kcQ-1 Received: by mail-oi1-f198.google.com with SMTP id 5614622812f47-3b2e2487c6bso1649252b6e.2 for ; Wed, 18 Oct 2023 01:44:34 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697618673; x=1698223473; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=k/0liIrEL7QSkgX7qVs1vHsvuoJgLIVTs8YD9K4UGPw=; b=uVeflt2SD/n4cE0l4NhcDbxT8tIxaoNGxfrUoGrWtH2ztS55QIz3X0Iy24zn+dryn+ 2rbAOzCpncE7oIFJicAECjWQXmnTwun9MKKX7JCIBlT+zUl/vUoi9pTyXo0eog5j+QyU 8q6EEea75ZIF0doSq9Nk91uanSm2HCYDmpWnEqPyJMovEgG5uFVRcN/X1Th6p3SKoC1m Lnpx4+b+rN3RbeROv2sCRorEfyWxry2n+G4u3WjQj7WI9xCe/tSA2NjXQzuFJ5fFZ6Y5 1KAmFD5/m9Qf3z7Fdjy4K6H7QuzaA6ABoGPM4UmCBNdzXOAwtMzvbs3go2E97chyBHLv JnCw== X-Gm-Message-State: AOJu0Yxhg+emu1zFjIRvQ9L6wReoG7F4fUAqPCtMNEdnn3Amlf7YQfs5 4hwHn5/aAcji7hScIGMRvELPD6I2XMH1zQjE0UvJ2fa2JoRkAOW77Yz3OfKxjT0eNmoYvb/7IxY jEIO+rnDvBmnexyaL X-Received: by 2002:a05:6808:3086:b0:3b2:e536:a442 with SMTP id bl6-20020a056808308600b003b2e536a442mr2351957oib.16.1697618673494; Wed, 18 Oct 2023 01:44:33 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEzPGIXQARJW6F6uNFF8ujwB+n068AiJDbzKEeMj1yIirMEG5lXUYwOTS07wjyM14GpSR797g== X-Received: by 2002:a05:6808:3086:b0:3b2:e536:a442 with SMTP id bl6-20020a056808308600b003b2e536a442mr2351949oib.16.1697618673200; Wed, 18 Oct 2023 01:44:33 -0700 (PDT) Received: from redhat.com ([193.142.201.38]) by smtp.gmail.com with ESMTPSA id v11-20020a54448b000000b003af732a2054sm581383oiv.57.2023.10.18.01.44.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Oct 2023 01:44:32 -0700 (PDT) Date: Wed, 18 Oct 2023 04:44:24 -0400 From: "Michael S. Tsirkin" To: Xuan Zhuo Cc: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Jason Wang , Alexei Starovoitov , Daniel Borkmann , Jesper Dangaard Brouer , John Fastabend , netdev@vger.kernel.org, bpf@vger.kernel.org, virtualization@lists.linux-foundation.org Subject: Re: [PATCH vhost 02/22] virtio_ring: introduce virtqueue_dma_[un]map_page_attrs Message-ID: <20231018044204-mutt-send-email-mst@kernel.org> References: <20231011092728.105904-1-xuanzhuo@linux.alibaba.com> <20231011092728.105904-3-xuanzhuo@linux.alibaba.com> <1697615580.6880193-1-xuanzhuo@linux.alibaba.com> <20231018035751-mutt-send-email-mst@kernel.org> <1697616022.630633-2-xuanzhuo@linux.alibaba.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1697616022.630633-2-xuanzhuo@linux.alibaba.com> X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL, SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net On Wed, Oct 18, 2023 at 04:00:22PM +0800, Xuan Zhuo wrote: > On Wed, 18 Oct 2023 03:59:03 -0400, "Michael S. Tsirkin" wrote: > > On Wed, Oct 18, 2023 at 03:53:00PM +0800, Xuan Zhuo wrote: > > > Hi Michael, > > > > > > Do you think it's appropriate to push the first two patches of this patch set to > > > linux 6.6? > > > > > > Thanks. > > > > I generally treat patchsets as a whole unless someone asks me to do > > otherwise. Why do you want this? > > As we discussed, the patch set supporting AF_XDP will be push to net-next. > But the two patchs belong to the vhost. > > So, if you think that is appropriate, I will post a new patchset(include the two > patchs without virtio-net + AF_XDP) to vhost. I wish that can be merged to 6.6. Oh wait 6.6? Too late really, merge window has been closed for weeks. > Then when the 6.7 net-next merge window is open, I can push this patch set to 6.7. > The v1 version use the virtqueue_dma_map_single_attrs to replace > virtqueue_dma_map_page_attrs. But I think we should use virtqueue_dma_map_page_attrs. > > Thanks. > Get a complete working patchset that causes no regressions posted first please then we will discuss merge strategy. I would maybe just put everything in one file for now, easier to merge, refactor later when it's all upstream. But up to you. > > > > -- > > MST > >