From: Jakub Kicinski <kuba@kernel.org>
To: Harald Welte <laforge@gnumonks.org>
Cc: takeru hayasaka <hayatake396@gmail.com>,
Jesse Brandeburg <jesse.brandeburg@intel.com>,
Tony Nguyen <anthony.l.nguyen@intel.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org,
Willem de Bruijn <willemdebruijn.kernel@gmail.com>,
Pablo Neira Ayuso <pablo@netfilter.org>,
osmocom-net-gprs@lists.osmocom.org
Subject: Re: [PATCH net-next v2] ethtool: ice: Support for RSS settings to GTP from ethtool
Date: Wed, 18 Oct 2023 10:40:15 -0700 [thread overview]
Message-ID: <20231018104015.42b2465b@kernel.org> (raw)
In-Reply-To: <ZS-TfMKAxHLEiXBl@nataraja>
On Wed, 18 Oct 2023 10:12:44 +0200 Harald Welte wrote:
> > If we were to propose again, setting aside considerations specific to
> > Intel, I believe, considering the users of ethtool, the smallest units
> > should be gtpu4|6 and gtpc4|6.
>
> agreed. Though I'm not entirely sure one would usually want to treat v4
> different from v6. I'd assume they would usually both follow the same
> RSS scheme?
FWIW I had the same thought. But if we do add flow matching
support for GTP one day we'll have to define a struct like
struct ethtool_tcpip4_spec, which means size of the address
matters?
next prev parent reply other threads:[~2023-10-18 17:40 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-12 6:01 [PATCH net-next v2] ethtool: ice: Support for RSS settings to GTP from ethtool Takeru Hayasaka
2023-10-16 9:27 ` Simon Horman
2023-10-16 22:23 ` Jakub Kicinski
2023-10-17 6:11 ` Harald Welte
2023-10-17 6:44 ` Harald Welte
2023-10-17 14:18 ` takeru hayasaka
2023-10-17 14:37 ` takeru hayasaka
2023-10-17 16:49 ` takeru hayasaka
2023-10-18 8:25 ` Harald Welte
2023-10-18 16:20 ` takeru hayasaka
2023-10-17 23:49 ` Jakub Kicinski
2023-10-18 1:53 ` takeru hayasaka
2023-10-18 8:12 ` Harald Welte
2023-10-18 17:40 ` Jakub Kicinski [this message]
2023-10-18 17:37 ` Jakub Kicinski
2023-10-18 17:57 ` Harald Welte
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231018104015.42b2465b@kernel.org \
--to=kuba@kernel.org \
--cc=anthony.l.nguyen@intel.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hayatake396@gmail.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jesse.brandeburg@intel.com \
--cc=laforge@gnumonks.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=osmocom-net-gprs@lists.osmocom.org \
--cc=pabeni@redhat.com \
--cc=pablo@netfilter.org \
--cc=willemdebruijn.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).