* [PATCH net v2] net: phy: bcm7xxx: Add missing 16nm EPHY statistics
@ 2023-10-17 20:51 Florian Fainelli
2023-10-18 13:52 ` Simon Horman
2023-10-19 1:20 ` patchwork-bot+netdevbpf
0 siblings, 2 replies; 3+ messages in thread
From: Florian Fainelli @ 2023-10-17 20:51 UTC (permalink / raw)
To: netdev
Cc: Florian Fainelli, Justin Chen, Andrew Lunn,
Broadcom internal kernel review list, Heiner Kallweit,
Russell King, David S. Miller, Eric Dumazet, Jakub Kicinski,
Paolo Abeni, open list
[-- Attachment #1: Type: text/plain, Size: 1116 bytes --]
The .probe() function would allocate the necessary space and ensure that
the library call sizes the nunber of statistics but the callbacks
necessary to fetch the name and values were not wired up.
Reported-by: Justin Chen <justin.chen@broadcom.com>
Fixes: f68d08c437f9 ("net: phy: bcm7xxx: Add EPHY entry for 72165")
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Signed-off-by: Florian Fainelli <florian.fainelli@broadcom.com>
---
drivers/net/phy/bcm7xxx.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/net/phy/bcm7xxx.c b/drivers/net/phy/bcm7xxx.c
index 8478b081c058..97638ba7ae85 100644
--- a/drivers/net/phy/bcm7xxx.c
+++ b/drivers/net/phy/bcm7xxx.c
@@ -894,6 +894,9 @@ static int bcm7xxx_28nm_probe(struct phy_device *phydev)
.name = _name, \
/* PHY_BASIC_FEATURES */ \
.flags = PHY_IS_INTERNAL, \
+ .get_sset_count = bcm_phy_get_sset_count, \
+ .get_strings = bcm_phy_get_strings, \
+ .get_stats = bcm7xxx_28nm_get_phy_stats, \
.probe = bcm7xxx_28nm_probe, \
.config_init = bcm7xxx_16nm_ephy_config_init, \
.config_aneg = genphy_config_aneg, \
--
2.34.1
[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4221 bytes --]
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH net v2] net: phy: bcm7xxx: Add missing 16nm EPHY statistics
2023-10-17 20:51 [PATCH net v2] net: phy: bcm7xxx: Add missing 16nm EPHY statistics Florian Fainelli
@ 2023-10-18 13:52 ` Simon Horman
2023-10-19 1:20 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: Simon Horman @ 2023-10-18 13:52 UTC (permalink / raw)
To: Florian Fainelli
Cc: netdev, Justin Chen, Andrew Lunn,
Broadcom internal kernel review list, Heiner Kallweit,
Russell King, David S. Miller, Eric Dumazet, Jakub Kicinski,
Paolo Abeni, open list
On Tue, Oct 17, 2023 at 01:51:19PM -0700, Florian Fainelli wrote:
> The .probe() function would allocate the necessary space and ensure that
> the library call sizes the nunber of statistics but the callbacks
> necessary to fetch the name and values were not wired up.
>
> Reported-by: Justin Chen <justin.chen@broadcom.com>
> Fixes: f68d08c437f9 ("net: phy: bcm7xxx: Add EPHY entry for 72165")
> Reviewed-by: Andrew Lunn <andrew@lunn.ch>
> Signed-off-by: Florian Fainelli <florian.fainelli@broadcom.com>
Reviewed-by: Simon Horman <horms@kernel.org>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH net v2] net: phy: bcm7xxx: Add missing 16nm EPHY statistics
2023-10-17 20:51 [PATCH net v2] net: phy: bcm7xxx: Add missing 16nm EPHY statistics Florian Fainelli
2023-10-18 13:52 ` Simon Horman
@ 2023-10-19 1:20 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2023-10-19 1:20 UTC (permalink / raw)
To: Florian Fainelli
Cc: netdev, justin.chen, andrew, bcm-kernel-feedback-list, hkallweit1,
linux, davem, edumazet, kuba, pabeni, linux-kernel
Hello:
This patch was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@kernel.org>:
On Tue, 17 Oct 2023 13:51:19 -0700 you wrote:
> The .probe() function would allocate the necessary space and ensure that
> the library call sizes the nunber of statistics but the callbacks
> necessary to fetch the name and values were not wired up.
>
> Reported-by: Justin Chen <justin.chen@broadcom.com>
> Fixes: f68d08c437f9 ("net: phy: bcm7xxx: Add EPHY entry for 72165")
> Reviewed-by: Andrew Lunn <andrew@lunn.ch>
> Signed-off-by: Florian Fainelli <florian.fainelli@broadcom.com>
>
> [...]
Here is the summary with links:
- [net,v2] net: phy: bcm7xxx: Add missing 16nm EPHY statistics
https://git.kernel.org/netdev/net/c/6200e00e112c
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-10-19 1:20 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-10-17 20:51 [PATCH net v2] net: phy: bcm7xxx: Add missing 16nm EPHY statistics Florian Fainelli
2023-10-18 13:52 ` Simon Horman
2023-10-19 1:20 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).