From: Michal Kubecek <mkubecek@suse.cz>
To: "Köry Maincent" <kory.maincent@bootlin.com>
Cc: Oleksij Rempel <o.rempel@pengutronix.de>,
"David S. Miller" <davem@davemloft.net>,
Andrew Lunn <andrew@lunn.ch>, Eric Dumazet <edumazet@google.com>,
Florian Fainelli <f.fainelli@gmail.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Vladimir Oltean <olteanv@gmail.com>,
kernel@pengutronix.de, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org
Subject: Re: [PATCH net v1 1/1] ethtool: fix clearing of WoL flags
Date: Thu, 19 Oct 2023 12:54:37 +0200 [thread overview]
Message-ID: <20231019105437.xvmvfhluowvubp2y@lion.mk-sys.cz> (raw)
In-Reply-To: <20231019105048.l64jp2nd46fxjewt@lion.mk-sys.cz>
[-- Attachment #1: Type: text/plain, Size: 404 bytes --]
On Thu, Oct 19, 2023 at 12:50:48PM +0200, Michal Kubecek wrote:
[...]
> @@ -490,6 +509,8 @@ ethnl_update_bitset32_verbose(u32 *bitmap, unsigned int nbits,
> *mod = true;
> }
> }
> + if (saved_bitmap)
> + *mod = ethnl_bitmap32_cmp(saved_bitmap, bitmap, nbits);
>
> ret = 0;
> out:
Oops, this should be
*mod = !ethnl_bitmap32_equal(saved_bitmap, bitmap, nbits);
Michal
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2023-10-19 10:54 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-19 7:09 [PATCH net v1 1/1] ethtool: fix clearing of WoL flags Oleksij Rempel
2023-10-19 9:05 ` Michal Kubecek
2023-10-19 9:12 ` Oleksij Rempel
2023-10-19 9:51 ` Michal Kubecek
2023-10-19 10:21 ` Köry Maincent
2023-10-19 10:50 ` Michal Kubecek
2023-10-19 10:54 ` Michal Kubecek [this message]
2023-10-19 13:27 ` Köry Maincent
2023-10-19 16:20 ` Florian Fainelli
2023-10-19 16:45 ` Michal Kubecek
2023-10-19 17:34 ` Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231019105437.xvmvfhluowvubp2y@lion.mk-sys.cz \
--to=mkubecek@suse.cz \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=kernel@pengutronix.de \
--cc=kory.maincent@bootlin.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=o.rempel@pengutronix.de \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox