From: Nandha Kumar Singaram <nandhakumar.singaram@gmail.com>
To: Simon Horman <horms@kernel.org>
Cc: Manish Chopra <manishc@marvell.com>,
GR-Linux-NIC-Dev@marvell.com, Coiby Xu <coiby.xu@gmail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
netdev@vger.kernel.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org, kumaran.4353@gmail.com
Subject: Re: [PATCH v2 1/2] staging: qlge: Fix coding style in qlge.h
Date: Thu, 19 Oct 2023 06:47:55 -0700 [thread overview]
Message-ID: <20231019134755.GB3373@ubuntu> (raw)
In-Reply-To: <20231019122740.GG2100445@kernel.org>
On Thu, Oct 19, 2023 at 02:27:40PM +0200, Simon Horman wrote:
> On Wed, Oct 18, 2023 at 12:46:00PM -0700, Nandha Kumar Singaram wrote:
> > Replace all occurrnces of (1<<x) by BIT(x) to get rid of checkpatch.pl
> > "CHECK" output "Prefer using the BIT macro"
> >
> > Signed-off-by: Nandha Kumar Singaram <nandhakumar.singaram@gmail.com>
>
> Thanks Nandha,
>
> these changes look good to me.
> But I would like to ask if not updating
> Q_LEN_V and LEN_V is intentional.
Thanks for the review Simon.
I have already sent a patch for Q_LEN_V and LEN_V and it is accepted
by greg k-h, so didn't updated here.
regards,
Nandha Kumar Singaram
next prev parent reply other threads:[~2023-10-19 13:48 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-18 19:45 [PATCH v2 0/2] staging: qlge: Replace the occurrences of (1<<x) by BIT(x) Nandha Kumar Singaram
2023-10-18 19:46 ` [PATCH v2 1/2] staging: qlge: Fix coding style in qlge.h Nandha Kumar Singaram
2023-10-19 12:27 ` Simon Horman
2023-10-19 13:47 ` Nandha Kumar Singaram [this message]
2023-10-19 15:55 ` Simon Horman
2023-10-18 19:47 ` [PATCH v2 2/2] staging: qlge: Prefer using the BIT macro Nandha Kumar Singaram
2023-10-19 12:29 ` Simon Horman
2023-10-21 9:54 ` [PATCH v2 0/2] staging: qlge: Replace the occurrences of (1<<x) by BIT(x) Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231019134755.GB3373@ubuntu \
--to=nandhakumar.singaram@gmail.com \
--cc=GR-Linux-NIC-Dev@marvell.com \
--cc=coiby.xu@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=horms@kernel.org \
--cc=kumaran.4353@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=manishc@marvell.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).