From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9607130FB0
	for <netdev@vger.kernel.org>; Thu, 19 Oct 2023 15:58:29 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org;
	dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Mir1vfOg"
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1C4B9C433C7;
	Thu, 19 Oct 2023 15:58:22 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1697731109;
	bh=bMzvQMdR1FFY3JOsuLWSMqDn7XLN36i9gNGyqjkvK48=;
	h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
	b=Mir1vfOgTzR55V1WKCUVIHJI7ZWoTaZ55a3JrJF3w4FhIF0QrWAwtJES8Nz/HE5q2
	 6QTER8wUwQcQnEwJnIMflv9be0dc1uT89bPb7r/B0h700Mtgee8aUKMx37pckn71F4
	 Ob5xXWcjqbQiOYbyxLu4otbWdZ09byM0Tp/cXcgUuVgCVhR7tclaKdcSVgOqdnIi0O
	 KAfm9Cez500PBXmYpEl8H79ik1RvRTaQrXsbBcNRUi/QVz5hOIkKYYjN7C/H1E9N/z
	 hNZk2Tb2W68H1iF10VcdofyZm7Tlo7Y2iLHporo9rthSPjhf5DwHU/Sbd6gyVhhtaX
	 4FmQh2nec1jQw==
Date: Thu, 19 Oct 2023 17:58:21 +0200
From: Simon Horman <horms@kernel.org>
To: Przemek Kitszel <przemyslaw.kitszel@intel.com>
Cc: Jiri Pirko <jiri@resnulli.us>, netdev@vger.kernel.org,
	"David S . Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Shannon Nelson <shannon.nelson@amd.com>,
	Michael Chan <michael.chan@broadcom.com>,
	Cai Huoqing <cai.huoqing@linux.dev>,
	George Cherian <george.cherian@marvell.com>,
	Danielle Ratson <danieller@nvidia.com>,
	Moshe Shemesh <moshe@nvidia.com>,
	Saeed Mahameed <saeedm@nvidia.com>,
	Ariel Elior <aelior@marvell.com>,
	Manish Chopra <manishc@marvell.com>,
	Igor Russkikh <irusskikh@marvell.com>,
	Coiby Xu <coiby.xu@gmail.com>,
	Brett Creeley <brett.creeley@amd.com>,
	Sunil Goutham <sgoutham@marvell.com>,
	Linu Cherian <lcherian@marvell.com>,
	Geetha sowjanya <gakula@marvell.com>,
	Jerin Jacob <jerinj@marvell.com>, hariprasad <hkelam@marvell.com>,
	Subbaraya Sundeep <sbhatta@marvell.com>,
	Ido Schimmel <idosch@nvidia.com>, Petr Machata <petrm@nvidia.com>,
	Eran Ben Elisha <eranbe@nvidia.com>, Aya Levin <ayal@mellanox.com>,
	Leon Romanovsky <leon@kernel.org>, linux-kernel@vger.kernel.org,
	Benjamin Poirier <bpoirier@suse.com>, Jiri Pirko <jiri@nvidia.com>
Subject: Re: [PATCH net-next v3 10/11] staging: qlge: devlink health: use
 retained error fmsg API
Message-ID: <20231019155821.GQ2100445@kernel.org>
References: <20231018202647.44769-1-przemyslaw.kitszel@intel.com>
 <20231018202647.44769-11-przemyslaw.kitszel@intel.com>
Precedence: bulk
X-Mailing-List: netdev@vger.kernel.org
List-Id: <netdev.vger.kernel.org>
List-Subscribe: <mailto:netdev+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:netdev+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20231018202647.44769-11-przemyslaw.kitszel@intel.com>

On Wed, Oct 18, 2023 at 10:26:46PM +0200, Przemek Kitszel wrote:
> Drop unneeded error checking.
> 
> devlink_fmsg_*() family of functions is now retaining errors,
> so there is no need to check for them after each call.
> 
> Reviewed-by: Jiri Pirko <jiri@nvidia.com>
> Signed-off-by: Przemek Kitszel <przemyslaw.kitszel@intel.com>

Reviewed-by: Simon Horman <horms@kernel.org>