From: Vladimir Oltean <olteanv@gmail.com>
To: "Russell King (Oracle)" <linux@armlinux.org.uk>
Cc: Oleksij Rempel <o.rempel@pengutronix.de>,
"David S. Miller" <davem@davemloft.net>,
Andrew Lunn <andrew@lunn.ch>, Eric Dumazet <edumazet@google.com>,
Florian Fainelli <f.fainelli@gmail.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Woojung Huh <woojung.huh@microchip.com>,
Arun Ramadoss <arun.ramadoss@microchip.com>,
Conor Dooley <conor+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
kernel@pengutronix.de, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org, UNGLinuxDriver@microchip.com,
devicetree@vger.kernel.org
Subject: Re: [PATCH net-next v6 5/9] net: dsa: microchip: ksz9477: Add Wake on Magic Packet support
Date: Fri, 20 Oct 2023 11:18:47 +0300 [thread overview]
Message-ID: <20231020081847.zgpez76utrexix24@skbuf> (raw)
In-Reply-To: <ZTFyvDLgmaTy2Csx@shell.armlinux.org.uk>
On Thu, Oct 19, 2023 at 07:17:32PM +0100, Russell King (Oracle) wrote:
> On Thu, Oct 19, 2023 at 08:29:53PM +0300, Vladimir Oltean wrote:
> > > - dev_dbg(dev->dev, "Wake event on port %d due to: %s %s\n", port,
> > > + dev_dbg(dev->dev, "Wake event on port %d due to: %s %s %s\n", port,
> > > + pme_status & PME_WOL_MAGICPKT ? "\"Magic Packet\"" : "",
> > > pme_status & PME_WOL_LINKUP ? "\"Link Up\"" : "",
> > > pme_status & PME_WOL_ENERGY ? "\"Enery detect\"" : "");
> >
> > Trivial: if you format the printf string as %s%s%s and the arguments as
> > "\"Magic Packet\" " : "", then the printed line won't have a trailing
> > space at the end.
>
> Sadly, it still will. The best solution is to prepend the space
> character to each entry in the "list" and remove the space characters
> after the : in the format string thusly:
>
> dev_dbg(dev->dev, "Wake event on port %d due to:%s%s%s\n", port,
> pme_status & PME_WOL_MAGICPKT ? " \"Magic Packet\"" : "",
> pme_status & PME_WOL_LINKUP ? " \"Link Up\"" : "",
> pme_status & PME_WOL_ENERGY ? " \"Enery detect\"" : "");
Thanks for correcting me.
next prev parent reply other threads:[~2023-10-20 8:18 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-19 12:28 [PATCH net-next v6 0/9] net: dsa: microchip: provide Wake on LAN support Oleksij Rempel
2023-10-19 12:28 ` [PATCH net-next v6 1/9] net: dsa: microchip: Add missing MAC address register offset for ksz8863 Oleksij Rempel
2023-10-19 12:30 ` Russell King (Oracle)
2023-10-19 17:05 ` Vladimir Oltean
2023-10-19 12:28 ` [PATCH net-next v6 2/9] dt-bindings: net: dsa: microchip: add wakeup-source property Oleksij Rempel
2023-10-19 12:28 ` [PATCH net-next v6 3/9] net: dsa: microchip: use wakeup-source DT property to enable PME output Oleksij Rempel
2023-10-19 12:28 ` [PATCH net-next v6 4/9] net: dsa: microchip: ksz9477: add Wake on LAN support Oleksij Rempel
2023-10-19 12:28 ` [PATCH net-next v6 5/9] net: dsa: microchip: ksz9477: Add Wake on Magic Packet support Oleksij Rempel
2023-10-19 16:18 ` Florian Fainelli
2023-10-19 17:29 ` Vladimir Oltean
2023-10-19 18:17 ` Russell King (Oracle)
2023-10-20 8:18 ` Vladimir Oltean [this message]
2023-10-20 5:08 ` Oleksij Rempel
2023-10-20 8:23 ` Vladimir Oltean
2023-10-20 8:29 ` Vladimir Oltean
2023-10-20 8:34 ` Oleksij Rempel
2023-10-20 21:41 ` Andrew Lunn
2023-10-19 12:28 ` [PATCH net-next v6 6/9] net: dsa: microchip: Refactor comment for ksz_switch_macaddr_get() function Oleksij Rempel
2023-10-19 17:10 ` Vladimir Oltean
2023-10-19 12:28 ` [PATCH net-next v6 7/9] net: dsa: microchip: Add error handling for ksz_switch_macaddr_get() Oleksij Rempel
2023-10-19 17:13 ` Vladimir Oltean
2023-10-19 17:19 ` Vladimir Oltean
2023-10-19 12:28 ` [PATCH net-next v6 8/9] net: dsa: microchip: Refactor switch shutdown routine for WoL preparation Oleksij Rempel
2023-10-19 17:25 ` Vladimir Oltean
2023-10-19 12:28 ` [PATCH net-next v6 9/9] net: dsa: microchip: Ensure Stable PME Pin State for Wake-on-LAN Oleksij Rempel
2023-10-19 17:24 ` Vladimir Oltean
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231020081847.zgpez76utrexix24@skbuf \
--to=olteanv@gmail.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=andrew@lunn.ch \
--cc=arun.ramadoss@microchip.com \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=kernel@pengutronix.de \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=o.rempel@pengutronix.de \
--cc=pabeni@redhat.com \
--cc=robh+dt@kernel.org \
--cc=woojung.huh@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox