From: Jakub Kicinski <kuba@kernel.org>
To: Jiri Pirko <jiri@resnulli.us>
Cc: davem@davemloft.net, netdev@vger.kernel.org, edumazet@google.com,
pabeni@redhat.com, johannes.berg@intel.com, mpe@ellerman.id.au,
j@w1.fi
Subject: Re: [PATCH net-next 2/6] net: make dev_alloc_name() call dev_prep_valid_name()
Date: Fri, 20 Oct 2023 12:01:49 -0700 [thread overview]
Message-ID: <20231020120149.3a569db7@kernel.org> (raw)
In-Reply-To: <ZTJVeUJy9WhOgiAU@nanopsycho>
On Fri, 20 Oct 2023 12:24:57 +0200 Jiri Pirko wrote:
> > static int dev_get_valid_name(struct net *net, struct net_device *dev,
> > const char *name)
> > {
> >- return dev_prep_valid_name(net, dev, name, dev->name);
> >+ int ret;
> >+
> >+ ret = dev_prep_valid_name(net, dev, name, dev->name, EEXIST);
> >+ return ret < 0 ? ret : 0;
>
> Why can't you just return dev_prep_valid_name() ?
>
> No caller seems to care about ret > 0
AFACT dev_change_name() has some weird code that ends up return
the value all the way to the ioctl and user space. Note that it
has both err and ret variables :S
next prev parent reply other threads:[~2023-10-20 19:01 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-20 1:18 [PATCH net-next 0/6] net: deduplicate netdev name allocation Jakub Kicinski
2023-10-20 1:18 ` [PATCH net-next 1/6] net: don't use input buffer of __dev_alloc_name() as a scratch space Jakub Kicinski
2023-10-20 10:15 ` Jiri Pirko
2023-10-20 1:18 ` [PATCH net-next 2/6] net: make dev_alloc_name() call dev_prep_valid_name() Jakub Kicinski
2023-10-20 10:24 ` Jiri Pirko
2023-10-20 19:01 ` Jakub Kicinski [this message]
2023-10-21 7:01 ` Jiri Pirko
2023-10-20 1:18 ` [PATCH net-next 3/6] net: reduce indentation of __dev_alloc_name() Jakub Kicinski
2023-10-20 10:26 ` Jiri Pirko
2023-10-20 1:18 ` [PATCH net-next 4/6] net: trust the bitmap in __dev_alloc_name() Jakub Kicinski
2023-10-20 10:38 ` Jiri Pirko
2023-10-20 19:04 ` Jakub Kicinski
2023-10-21 7:00 ` Jiri Pirko
2023-10-20 1:18 ` [PATCH net-next 5/6] net: remove dev_valid_name() check from __dev_alloc_name() Jakub Kicinski
2023-10-20 10:39 ` Jiri Pirko
2023-10-20 1:18 ` [PATCH net-next 6/6] net: remove else after return in dev_prep_valid_name() Jakub Kicinski
2023-10-20 10:45 ` Jiri Pirko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231020120149.3a569db7@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=j@w1.fi \
--cc=jiri@resnulli.us \
--cc=johannes.berg@intel.com \
--cc=mpe@ellerman.id.au \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).