From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CD5D3321AD; Fri, 20 Oct 2023 22:05:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="YaavavBn" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 09317C433C7; Fri, 20 Oct 2023 22:05:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1697839558; bh=y2bK7Rld1GZZCtSFjbtlqtGNkpjPpl8o4DNjguzr4B8=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=YaavavBncXq7wevwgeAJO1GhimQe1EOmyLMvmZScW1QA2GQyHN+n/1pkf4mE84i1o 9Fv6s/3hw2c8RLw47ICeptfdTSDA5V7AFgnITJioLkqIF+zZZV21qBKxmAtXBOI5nS JDGlTWVwqIw+mgbEoDbqVeD8W7DE3ua0BCERMVWY9ZSPLI/yiQs1etNZoSm2jj50Hs N92SUW/52jRHQw3F4ly4TzLlRli14Ol6Ege3OVLgp0qaVMdgd6ykx/uL3KNSdm5skJ mYr1h2kleZt+f0Iu0edLEUIQtk+8x8/dSjXg4v9tF4LzaHrowO9fZ/mlDCgI7XtwL5 IAs7Aqcolu7CQ== Date: Fri, 20 Oct 2023 15:05:57 -0700 From: Jakub Kicinski To: "Nambiar, Amritha" , Cc: kernel test robot , , Subject: Re: [net-next PATCH v5 01/10] netdev-genl: spec: Extend netdev netlink spec in YAML for queue Message-ID: <20231020150557.00af950d@kernel.org> In-Reply-To: References: <169767396671.6692.9945461089943525792.stgit@anambiarhost.jf.intel.com> <202310190900.9Dzgkbev-lkp@intel.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Fri, 20 Oct 2023 13:26:38 -0700 Nambiar, Amritha wrote: > > WARNING:SPACING: space prohibited between function name and open parenthesis '(' > > #547: FILE: tools/net/ynl/generated/netdev-user.h:181: > > + struct netdev_queue_get_rsp obj __attribute__ ((aligned (8))); > > Looks like the series is in "Changes Requested" state following these > warnings. Is there any recommendation for warnings on generated code? I > see similar issues on existing code in the generated file. Yes, ignore this one. I'll post a change to the codegen. The warning on patch 3 is legit, right? kernel test bot folks, please be careful with the checkpatch warnings. Some of them are bogus. TBH I'm not sure how much value running checkpatch in the bot adds. It's really trivial to run for the maintainers when applying patches.