From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 947421C297 for ; Mon, 23 Oct 2023 15:23:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Kn/3wQ7+" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1A3EDC4339A; Mon, 23 Oct 2023 15:23:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1698074630; bh=Ytxjxu7vOC51znHtTmSEisbsPOCPk9XldSLYyVun6eE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Kn/3wQ7+QPR5RViOa8UZu+VJI5CBJvY1vlNSggNX8ykoGo1Wotidtp6LpCM+ttwJg qRTFM3ToKUVktXDB9aI99ydn4MF0+Wbwut303nq0oSFkqSJ+91ePQHIwFjMzQiOpdv +JOQ4WL44lqceMvrPIx45EB7gt1ZhTbq+qHNgnv98Jqpn0gX2wJn0cSepDE1tfeN68 i+Lqpe5ZmUdkLKORU8LEcK5W1zFEWXEbaGoxkJjG7+EUWUWkg/VABtSPSipn1yqFQx 4rOzpbeHJM4fER/zT47qnTq9yoxWbss9cvXGYgN/eGGaVsaws6o7Iba+5/n98Owjgl i6QUv5JgIx+VA== From: Jakub Kicinski To: davem@davemloft.net Cc: netdev@vger.kernel.org, edumazet@google.com, pabeni@redhat.com, johannes.berg@intel.com, mpe@ellerman.id.au, j@w1.fi, jiri@resnulli.us Subject: [PATCH net-next v2 5/6] net: remove dev_valid_name() check from __dev_alloc_name() Date: Mon, 23 Oct 2023 08:23:45 -0700 Message-ID: <20231023152346.3639749-6-kuba@kernel.org> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20231023152346.3639749-1-kuba@kernel.org> References: <20231023152346.3639749-1-kuba@kernel.org> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit __dev_alloc_name() is only called by dev_prep_valid_name(), which already checks that name is valid. Reviewed-by: Jiri Pirko Signed-off-by: Jakub Kicinski --- net/core/dev.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/net/core/dev.c b/net/core/dev.c index d2698b4bbad4..0830f2967221 100644 --- a/net/core/dev.c +++ b/net/core/dev.c @@ -1077,9 +1077,6 @@ static int __dev_alloc_name(struct net *net, const char *name, char *res) struct net_device *d; char buf[IFNAMSIZ]; - if (!dev_valid_name(name)) - return -EINVAL; - /* Verify the string as this thing may have come from the user. * There must be one "%d" and no other "%" characters. */ -- 2.41.0