From: Florian Westphal <fw@strlen.de>
To: Yan Zhai <yan@cloudflare.com>
Cc: netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>,
David Ahern <dsahern@kernel.org>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Aya Levin <ayal@nvidia.com>, Tariq Toukan <tariqt@nvidia.com>,
linux-kernel@vger.kernel.org, kernel-team@cloudflare.com,
Florian Westphal <fw@strlen.de>,
Willem de Bruijn <willemdebruijn.kernel@gmail.com>,
Alexander H Duyck <alexander.duyck@gmail.com>
Subject: Re: [PATCH v4 net-next 1/3] ipv6: drop feature RTAX_FEATURE_ALLFRAG
Date: Tue, 24 Oct 2023 12:22:01 +0200 [thread overview]
Message-ID: <20231024102201.GB2255@breakpoint.cc> (raw)
In-Reply-To: <a79fe77d7308f7e6de7a019f23a509b84cbacd79.1698114636.git.yan@cloudflare.com>
Yan Zhai <yan@cloudflare.com> wrote:
> #define IPCORK_OPT 1 /* ip-options has been held in ipcork.opt */
> -#define IPCORK_ALLFRAG 2 /* always fragment (for ipv6 for now) */
> +#define IPCORK_ALLFRAG 2 /* (unused) always fragment (for ipv6 for now) */
Nit: Why not remove the ALLFRAG define as well?
Otherwise the series looks good to me, thanks!
Reviewed-by: Florian Westphal <fw@strlen.de>
next prev parent reply other threads:[~2023-10-24 10:22 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-24 2:35 [PATCH v4 net-next 0/3] ipv6: avoid atomic fragment on GSO output Yan Zhai
2023-10-24 2:35 ` [PATCH v4 net-next 1/3] ipv6: drop feature RTAX_FEATURE_ALLFRAG Yan Zhai
2023-10-24 10:22 ` Florian Westphal [this message]
2023-10-24 10:30 ` Eric Dumazet
2023-10-24 14:28 ` Yan Zhai
2023-10-24 2:35 ` [PATCH v4 net-next 2/3] ipv6: refactor ip6_finish_output for GSO handling Yan Zhai
2023-10-24 2:35 ` [PATCH v4 net-next 3/3] ipv6: avoid atomic fragment on GSO packets Yan Zhai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231024102201.GB2255@breakpoint.cc \
--to=fw@strlen.de \
--cc=alexander.duyck@gmail.com \
--cc=ayal@nvidia.com \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=kernel-team@cloudflare.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=tariqt@nvidia.com \
--cc=willemdebruijn.kernel@gmail.com \
--cc=yan@cloudflare.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).