From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 90FDB1C3E for ; Tue, 24 Oct 2023 10:22:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=none Received: from Chamillionaire.breakpoint.cc (Chamillionaire.breakpoint.cc [IPv6:2a0a:51c0:0:237:300::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C60BCAC; Tue, 24 Oct 2023 03:22:14 -0700 (PDT) Received: from fw by Chamillionaire.breakpoint.cc with local (Exim 4.92) (envelope-from ) id 1qvEXx-0007XI-Co; Tue, 24 Oct 2023 12:22:01 +0200 Date: Tue, 24 Oct 2023 12:22:01 +0200 From: Florian Westphal To: Yan Zhai Cc: netdev@vger.kernel.org, "David S. Miller" , David Ahern , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Aya Levin , Tariq Toukan , linux-kernel@vger.kernel.org, kernel-team@cloudflare.com, Florian Westphal , Willem de Bruijn , Alexander H Duyck Subject: Re: [PATCH v4 net-next 1/3] ipv6: drop feature RTAX_FEATURE_ALLFRAG Message-ID: <20231024102201.GB2255@breakpoint.cc> References: Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Yan Zhai wrote: > #define IPCORK_OPT 1 /* ip-options has been held in ipcork.opt */ > -#define IPCORK_ALLFRAG 2 /* always fragment (for ipv6 for now) */ > +#define IPCORK_ALLFRAG 2 /* (unused) always fragment (for ipv6 for now) */ Nit: Why not remove the ALLFRAG define as well? Otherwise the series looks good to me, thanks! Reviewed-by: Florian Westphal