From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 230546FA6 for ; Tue, 24 Oct 2023 17:49:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Cz5+LNIl" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5C74BC433C7; Tue, 24 Oct 2023 17:49:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1698169751; bh=HZFfZ4p5R5ufKIODptS4GZrknXlxe48G7GXWWJWt8uU=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=Cz5+LNIlQsYorQ4WiyOtT7+FVBaFieqyc/EeQ3o7pn/nITIf9dxh8CdcETcx8UKM1 J0kbzPuUZA6vEaU/ojoya9vEjmO/yZ2CM/6olbIuiyj+U/sInUReFgnrtYub5L7Dy/ BcupzZv2JaXRzICZ5p58i4FVFpQ9HGc7ce5Jf4+nZTHvS7AfH73Ci9IeZKvsyaPSdn 9ZUo0aUzRRz10F8H21n5IkxpwWbaaWl5NqvgJAGF1NhAc+rdx0yTcbSJ/AGL9NBul3 MGmLxfm85IDenXj4M1eFGovyti3TJBRrTUSIDKybahcoxFVudnE6K575zaf/nfmv9k 8UDnI4w1BiwmQ== Date: Tue, 24 Oct 2023 10:49:10 -0700 From: Jakub Kicinski To: David Ahern Cc: davem@davemloft.net, netdev@vger.kernel.org, edumazet@google.com, pabeni@redhat.com, almasrymina@google.com, hawk@kernel.org, ilias.apalodimas@linaro.org Subject: Re: [PATCH net-next 05/15] net: page_pool: record pools per netdev Message-ID: <20231024104910.71ced925@kernel.org> In-Reply-To: References: <20231024160220.3973311-1-kuba@kernel.org> <20231024160220.3973311-6-kuba@kernel.org> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Tue, 24 Oct 2023 11:31:46 -0600 David Ahern wrote: > On 10/24/23 10:02 AM, Jakub Kicinski wrote: > > Link the page pools with netdevs. This needs to be netns compatible > > so we have two options. Either we record the pools per netns and > > have to worry about moving them as the netdev gets moved. > > Or we record them directly on the netdev so they move with the netdev > > without any extra work. > > > > Implement the latter option. Since pools may outlast netdev we need > > a place to store orphans. In time honored tradition use loopback > > for this purpose. > > blackhole_netdev might be a better choice than loopback With loopback we still keep it per netns, and still accessible via netlink.