From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6CCAD266A9 for ; Tue, 24 Oct 2023 19:48:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="ZIO7y985" Received: by smtp.kernel.org (Postfix) with ESMTPSA id A7DC9C433C7; Tue, 24 Oct 2023 19:48:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1698176933; bh=cD2e1TlbZi88hgt3F5DztT/T6aBFB6sAIbsycdAqO/8=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=ZIO7y985StqtaP7K3IB81DAD/vWjNY4//YfGcWMj8crooxjZlEQC4lwauoBgKY9ZW ru7ZmkFntQx6t0alcSkFD+ekVmVJ0LwAT8dUV4j0GsTW25jv5XxH82p/2Wxzncf49E 9x1PJ/LnRxHHI4ebPsN3tbTUaOuUtf3SdUkQXbxDFlcB5IyjgZikEs9rLqOaABt0h0 0MB6Mlwm/P6YT3D9NsHH1/y+uU2e8pm1IGOhvh9p1tzpgaHHsANHl4jkc5FLjUHa6N ttjbgZAs8eekiOe+S59U3wcjHLY16xuc3/xeripNJFtgYVgiL5jVba9a11Dt6gca0j Q0JxWmHPo7kvg== Date: Tue, 24 Oct 2023 12:48:51 -0700 From: Jakub Kicinski To: Alex Henrie Cc: netdev@vger.kernel.org, jbohac@suse.cz, benoit.boissinot@ens-lyon.org, davem@davemloft.net, hideaki.yoshifuji@miraclelinux.com, dsahern@kernel.org, pabeni@redhat.com Subject: Re: [PATCH resend 1/4] net: ipv6/addrconf: clamp preferred_lft to the maximum allowed Message-ID: <20231024124851.354e2e09@kernel.org> In-Reply-To: <20231024194010.99995-1-alexhenrie24@gmail.com> References: <20230829054623.104293-1-alexhenrie24@gmail.com> <20231024194010.99995-1-alexhenrie24@gmail.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Tue, 24 Oct 2023 13:40:01 -0600 Alex Henrie wrote: > Without this patch, there is nothing to stop the preferred lifetime of a > temporary address from being greater than its valid lifetime. If that > was the case, the valid lifetime was effectively ignored. Please: - add cover letter, with the changes from v2 - PATCH net-next v2 in the subject prefix - do not post in-reply-to, instead put a lore link: https://lore.kernel.org/all/20230829054623.104293-1-alexhenrie24@gmail.com/ to the v2 in the cover letter.