From: Jakub Kicinski <kuba@kernel.org>
To: Mat Martineau <martineau@kernel.org>
Cc: "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
Matthieu Baerts <matttbe@kernel.org>,
netdev@vger.kernel.org, mptcp@lists.linux.dev,
Simon Horman <horms@kernel.org>,
Davide Caratti <dcaratti@redhat.com>
Subject: Re: [PATCH net-next v2 5/7] uapi: mptcp: use header file generated from YAML spec
Date: Tue, 24 Oct 2023 12:59:56 -0700 [thread overview]
Message-ID: <20231024125956.341ef4ef@kernel.org> (raw)
In-Reply-To: <20231023-send-net-next-20231023-1-v2-5-16b1f701f900@kernel.org>
On Mon, 23 Oct 2023 11:17:09 -0700 Mat Martineau wrote:
> +/* for backward compatibility */
> +#define __MPTCP_PM_CMD_AFTER_LAST __MPTCP_PM_CMD_MAX
> +#define __MPTCP_ATTR_AFTER_LAST __MPTCP_ATTR_MAX
Do you want to intentionally move to the normal naming or would you
prefer to keep the old names?
We have attr-cnt-name / attr-max-name for migrating existing families.
We can add similar properties for cmd if you prefer, I think that they
were not needed before.
next prev parent reply other threads:[~2023-10-24 19:59 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-23 18:17 [PATCH net-next v2 0/7] mptcp: convert Netlink code to use YAML spec Mat Martineau
2023-10-23 18:17 ` [PATCH net-next v2 1/7] tools: ynl: add uns-admin-perm to genetlink legacy Mat Martineau
2023-10-23 18:17 ` [PATCH net-next v2 2/7] tools: ynl-gen: add support for exact-len validation Mat Martineau
2023-10-23 18:17 ` [PATCH net-next v2 3/7] net: mptcp: convert netlink from small_ops to ops Mat Martineau
2023-10-23 18:17 ` [PATCH net-next v2 4/7] Documentation: netlink: add a YAML spec for mptcp Mat Martineau
2023-10-23 18:17 ` [PATCH net-next v2 5/7] uapi: mptcp: use header file generated from YAML spec Mat Martineau
2023-10-24 19:59 ` Jakub Kicinski [this message]
2023-10-24 23:30 ` Mat Martineau
2023-10-24 23:49 ` Jakub Kicinski
2023-10-24 23:50 ` Jakub Kicinski
2023-10-25 16:40 ` Davide Caratti
2023-10-25 18:18 ` Jakub Kicinski
2023-10-23 18:17 ` [PATCH net-next v2 6/7] net: mptcp: rename netlink handlers to mptcp_pm_nl_<blah>_{doit,dumpit} Mat Martineau
2023-10-23 18:17 ` [PATCH net-next v2 7/7] net: mptcp: use policy generated by YAML spec Mat Martineau
2023-10-24 20:10 ` [PATCH net-next v2 0/7] mptcp: convert Netlink code to use " patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231024125956.341ef4ef@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=dcaratti@redhat.com \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=martineau@kernel.org \
--cc=matttbe@kernel.org \
--cc=mptcp@lists.linux.dev \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).