From: Jakub Kicinski <kuba@kernel.org>
To: Amritha Nambiar <amritha.nambiar@intel.com>
Cc: netdev@vger.kernel.org, pabeni@redhat.com, sridhar.samudrala@intel.com
Subject: Re: [net-next PATCH v6 06/10] netdev-genl: Add netlink framework functions for napi
Date: Tue, 24 Oct 2023 15:39:41 -0700 [thread overview]
Message-ID: <20231024153941.4c05da4b@kernel.org> (raw)
In-Reply-To: <169811123039.59034.9768807608201356902.stgit@anambiarhost.jf.intel.com>
On Mon, 23 Oct 2023 18:33:50 -0700 Amritha Nambiar wrote:
> + rcu_read_lock();
> +
> + napi = napi_by_id(napi_id);
> + if (napi)
> + err = netdev_nl_napi_fill_one(rsp, napi, info);
> + else
> + err = -EINVAL;
> +
> + rcu_read_unlock();
Is rcu_read_lock always going to be sufficient here?
Reading of the thread, for example, without much locking could
potentially get problematic.
next prev parent reply other threads:[~2023-10-24 22:39 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-24 1:33 [net-next PATCH v6 00/10] Introduce queue and NAPI support in netdev-genl (Was: Introduce NAPI queues support) Amritha Nambiar
2023-10-24 1:33 ` [net-next PATCH v6 01/10] netdev-genl: spec: Extend netdev netlink spec in YAML for queue Amritha Nambiar
2023-10-24 22:45 ` Jakub Kicinski
2023-10-25 2:19 ` Nambiar, Amritha
2023-10-24 1:33 ` [net-next PATCH v6 02/10] net: Add queue and napi association Amritha Nambiar
2023-10-24 1:33 ` [net-next PATCH v6 03/10] ice: Add support in the driver for associating queue with napi Amritha Nambiar
2023-10-24 1:33 ` [net-next PATCH v6 04/10] netdev-genl: Add netlink framework functions for queue Amritha Nambiar
2023-10-24 1:33 ` [net-next PATCH v6 05/10] netdev-genl: spec: Extend netdev netlink spec in YAML for NAPI Amritha Nambiar
2023-10-24 22:47 ` Jakub Kicinski
2023-10-25 2:20 ` Nambiar, Amritha
2023-10-24 1:33 ` [net-next PATCH v6 06/10] netdev-genl: Add netlink framework functions for napi Amritha Nambiar
2023-10-24 22:39 ` Jakub Kicinski [this message]
2023-10-25 2:18 ` Nambiar, Amritha
2023-10-24 1:33 ` [net-next PATCH v6 07/10] netdev-genl: spec: Add irq in netdev netlink YAML spec Amritha Nambiar
2023-10-24 1:34 ` [net-next PATCH v6 08/10] net: Add NAPI IRQ support Amritha Nambiar
2023-10-24 23:29 ` Florian Fainelli
2023-10-25 2:29 ` Nambiar, Amritha
2023-10-24 1:34 ` [net-next PATCH v6 09/10] netdev-genl: spec: Add PID in netdev netlink YAML spec Amritha Nambiar
2023-10-24 22:50 ` Jakub Kicinski
2023-10-25 2:25 ` Nambiar, Amritha
2023-10-24 1:34 ` [net-next PATCH v6 10/10] netdev-genl: Add PID for the NAPI thread Amritha Nambiar
2023-10-24 22:51 ` [net-next PATCH v6 00/10] Introduce queue and NAPI support in netdev-genl (Was: Introduce NAPI queues support) Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231024153941.4c05da4b@kernel.org \
--to=kuba@kernel.org \
--cc=amritha.nambiar@intel.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sridhar.samudrala@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).