From: Jakub Kicinski <kuba@kernel.org>
To: Jacob Keller <jacob.e.keller@intel.com>
Cc: netdev@vger.kernel.org, David Miller <davem@davemloft.net>,
Michal Schmidt <mschmidt@redhat.com>,
Wojciech Drewek <wojciech.drewek@intel.com>,
Rafal Romanowski <rafal.romanowski@intel.com>
Subject: Re: [PATCH net-next 4/9] iavf: in iavf_down, disable queues when removing the driver
Date: Tue, 24 Oct 2023 16:42:34 -0700 [thread overview]
Message-ID: <20231024164234.46e9bb5f@kernel.org> (raw)
In-Reply-To: <20231023230826.531858-6-jacob.e.keller@intel.com>
On Mon, 23 Oct 2023 16:08:21 -0700 Jacob Keller wrote:
> From: Michal Schmidt <mschmidt@redhat.com>
>
> In iavf_down, we're skipping the scheduling of certain operations if
> the driver is being removed. However, the IAVF_FLAG_AQ_DISABLE_QUEUES
> request must not be skipped in this case, because iavf_close waits
> for the transition to the __IAVF_DOWN state, which happens in
> iavf_virtchnl_completion after the queues are released.
>
> Without this fix, "rmmod iavf" takes half a second per interface that's
> up and prints the "Device resources not yet released" warning.
>
> Fixes: c8de44b577eb ("iavf: do not process adminq tasks when __IAVF_IN_REMOVE_TASK is set")
This looks like a 6.6 regression, why send it for net-next?
next prev parent reply other threads:[~2023-10-24 23:42 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-23 23:08 [PATCH net-next 0/9] Intel Wired LAN Driver Updates for 2023-10-23 (iavf) Jacob Keller
2023-10-23 23:08 ` [PATCH net-next 1/1] iavf: delete the iavf client interface Jacob Keller
2023-10-23 23:08 ` [PATCH net-next 1/9] iavf: fix comments about old bit locks Jacob Keller
2023-10-23 23:08 ` [PATCH net-next 2/9] iavf: simplify mutex_trylock+sleep loops Jacob Keller
2023-10-23 23:08 ` [PATCH net-next 3/9] iavf: in iavf_down, don't queue watchdog_task if comms failed Jacob Keller
2023-10-23 23:08 ` [PATCH net-next 4/9] iavf: in iavf_down, disable queues when removing the driver Jacob Keller
2023-10-24 23:42 ` Jakub Kicinski [this message]
2023-10-25 15:24 ` Michal Schmidt
2023-10-25 16:25 ` Jakub Kicinski
2023-10-25 17:23 ` Jacob Keller
2023-10-25 18:32 ` Jacob Keller
2023-10-23 23:08 ` [PATCH net-next 5/9] iavf: fix the waiting time for initial reset Jacob Keller
2023-10-23 23:08 ` [PATCH net-next 6/9] iavf: rely on netdev's own registered state Jacob Keller
2023-10-23 23:08 ` [PATCH net-next 7/9] iavf: use unregister_netdev Jacob Keller
2023-10-24 23:44 ` Jakub Kicinski
2023-10-23 23:08 ` [PATCH net-next 8/9] iavf: add a common function for undoing the interrupt scheme Jacob Keller
2023-10-23 23:08 ` [PATCH net-next 9/9] iavf: delete the iavf client interface Jacob Keller
2023-10-27 16:58 ` [PATCH net-next 0/9] Intel Wired LAN Driver Updates for 2023-10-23 (iavf) Jacob Keller
2023-10-27 17:41 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231024164234.46e9bb5f@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=jacob.e.keller@intel.com \
--cc=mschmidt@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=rafal.romanowski@intel.com \
--cc=wojciech.drewek@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).