From: Vladimir Oltean <olteanv@gmail.com>
To: Luiz Angelo Daros de Luca <luizluca@gmail.com>
Cc: Florian Fainelli <f.fainelli@gmail.com>,
netdev@vger.kernel.org, linus.walleij@linaro.org,
alsi@bang-olufsen.dk, andrew@lunn.ch, vivien.didelot@gmail.com,
davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com,
robh+dt@kernel.org, krzk+dt@kernel.org, arinc.unal@arinc9.com
Subject: Re: [PATCH net-next 1/2] net: dsa: realtek: support reset controller
Date: Wed, 25 Oct 2023 01:07:25 +0300 [thread overview]
Message-ID: <20231024220725.4rlaq7ma3vc2l5qf@skbuf> (raw)
In-Reply-To: <CAJq09z4=QZOZ7mvmrPrs4Ne+TCyMZ5k276Kz8Ud+ty9qAmW2WA@mail.gmail.com>
On Tue, Oct 24, 2023 at 07:02:33PM -0300, Luiz Angelo Daros de Luca wrote:
> > Empty stubs are provided when CONFIG_RESET_CONTROLLER is disabled
>
> Nice! I'll drop the "#ifdef"s.
>
> > if you switch to using devm_reset_control_get() then you will get a NULL
> > reset_control reference which will be a no-op for all of those operations.
>
> I'm already using devm_reset_control_get(). Maybe you copied the wrong
> name? Did you mean devm_reset_control_get_optional()?
> It is, indeed, what I needed. Thanks.
Please also wait for a review on the device tree binding change before
posting a v2.
next prev parent reply other threads:[~2023-10-24 22:07 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-24 20:58 [PATCH net-next 1/2] net: dsa: realtek: support reset controller Luiz Angelo Daros de Luca
2023-10-24 20:58 ` [PATCH net-next 2/2] dt-bindings: net: dsa: realtek: add " Luiz Angelo Daros de Luca
2023-10-24 22:39 ` Vladimir Oltean
2023-10-26 10:34 ` Arınç ÜNAL
2023-10-26 20:09 ` Luiz Angelo Daros de Luca
2023-10-26 20:58 ` Rob Herring
2023-10-26 22:03 ` Luiz Angelo Daros de Luca
2023-10-24 21:09 ` [PATCH net-next 1/2] net: dsa: realtek: support " Florian Fainelli
2023-10-24 22:02 ` Luiz Angelo Daros de Luca
2023-10-24 22:06 ` Florian Fainelli
2023-10-24 22:07 ` Vladimir Oltean [this message]
2023-10-24 22:17 ` Luiz Angelo Daros de Luca
2023-10-24 22:32 ` Andrew Lunn
2023-10-24 22:33 ` Vladimir Oltean
2023-10-25 18:30 ` Luiz Angelo Daros de Luca
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231024220725.4rlaq7ma3vc2l5qf@skbuf \
--to=olteanv@gmail.com \
--cc=alsi@bang-olufsen.dk \
--cc=andrew@lunn.ch \
--cc=arinc.unal@arinc9.com \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=krzk+dt@kernel.org \
--cc=kuba@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=luizluca@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=robh+dt@kernel.org \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox