From: Jakub Kicinski <kuba@kernel.org>
To: Willem de Bruijn <willemdebruijn.kernel@gmail.com>
Cc: netdev@vger.kernel.org, davem@davemloft.net, edumazet@google.com,
pabeni@redhat.com, Willem de Bruijn <willemb@google.com>,
syzbot+a8c7be6dee0de1b669cc@syzkaller.appspotmail.com,
joonwpark81@gmail.com
Subject: Re: [PATCH net] llc: verify mac len before reading mac header
Date: Wed, 25 Oct 2023 16:00:16 -0700 [thread overview]
Message-ID: <20231025160016.0ffecfac@kernel.org> (raw)
In-Reply-To: <CAF=yD-L8MobHEPvELTKkvpm4WAZAVPbJKqXnjnkaD7qr32NBEQ@mail.gmail.com>
On Tue, 24 Oct 2023 23:12:13 -0400 Willem de Bruijn wrote:
> Fixes: f83f1768f833 ("[LLC]: skb allocation size for responses")
>
> Can respin if necessary.
>
> At least one of the three eth_hdr uses goes back to before the start
> of git history.
Right, good enough.
> But the one that syzbot exercises is introduced in this commit.
>
> That commit is old enough (2008), that effectively all stable kernels
> should receive this. This commit also introduces llc_mac_header_len,
> which shows at least one valid L2 header that is not an Ethernet
> header, back in the day:
>
> +#ifdef CONFIG_TR
> + case ARPHRD_IEEE802_TR:
> + return sizeof(struct trh_hdr);
> +#endif
>
> But that token ring variant was removed in 2012 in commit 211ed865108e
> ("net: delete all instances of special processing for token ring").
next prev parent reply other threads:[~2023-10-25 23:00 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-24 19:49 [PATCH net] llc: verify mac len before reading mac header Willem de Bruijn
2023-10-25 3:12 ` Willem de Bruijn
2023-10-25 23:00 ` Jakub Kicinski [this message]
2023-10-25 7:09 ` Eric Dumazet
2023-10-25 23:01 ` Jakub Kicinski
2023-10-25 23:05 ` Willem de Bruijn
2023-10-25 23:14 ` Jakub Kicinski
2023-10-25 23:18 ` Willem de Bruijn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231025160016.0ffecfac@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=joonwpark81@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=syzbot+a8c7be6dee0de1b669cc@syzkaller.appspotmail.com \
--cc=willemb@google.com \
--cc=willemdebruijn.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).