From: Jakub Kicinski <kuba@kernel.org>
To: Coco Li <lixiaoyan@google.com>
Cc: Eric Dumazet <edumazet@google.com>,
Neal Cardwell <ncardwell@google.com>,
Mubashir Adnan Qureshi <mubashirq@google.com>,
Paolo Abeni <pabeni@redhat.com>, Andrew Lunn <andrew@lunn.ch>,
Jonathan Corbet <corbet@lwn.net>,
David Ahern <dsahern@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
netdev@vger.kernel.org, Chao Wu <wwchao@google.com>,
Wei Wang <weiwan@google.com>,
Pradeep Nemavat <pnemavat@google.com>
Subject: Re: [PATCH v4 net-next 2/6] cache: enforce cache groups
Date: Thu, 26 Oct 2023 07:17:01 -0700 [thread overview]
Message-ID: <20231026071701.62237118@kernel.org> (raw)
In-Reply-To: <20231026081959.3477034-3-lixiaoyan@google.com>
On Thu, 26 Oct 2023 08:19:55 +0000 Coco Li wrote:
> Set up build time warnings to safegaurd against future header changes
> of organized structs.
TBH I had some doubts about the value of these asserts, I thought
it was just me but I was talking to Vadim F and he brought up
the same question.
IIUC these markings will protect us from people moving the members
out of the cache lines. Does that actually happen?
It'd be less typing to assert the _size_ of each group, which protects
from both moving out, and adding stuff haphazardly, which I'd guess is
more common. Perhaps we should do that in addition?
next prev parent reply other threads:[~2023-10-26 14:17 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-26 8:19 [PATCH v4 net-next 0/6] Analyze and Reorganize core Networking Structs to optimize cacheline consumption Coco Li
2023-10-26 8:19 ` [PATCH v4 net-next 1/6] Documentations: Analyze heavily used Networking related structs Coco Li
2023-10-26 8:19 ` [PATCH v4 net-next 2/6] cache: enforce cache groups Coco Li
2023-10-26 9:42 ` Eric Dumazet
2023-10-26 14:17 ` Jakub Kicinski [this message]
2023-10-26 23:39 ` Kuniyuki Iwashima
2023-10-26 23:50 ` Coco Li
2023-10-27 8:01 ` Eric Dumazet
2023-10-27 8:21 ` Daniel Borkmann
2023-10-26 8:19 ` [PATCH v4 net-next 3/6] net-smnp: reorganize SNMP fast path variables Coco Li
2023-10-26 14:20 ` Jakub Kicinski
2023-10-26 23:52 ` Coco Li
2023-10-27 1:23 ` Jakub Kicinski
2023-10-27 7:55 ` Eric Dumazet
2023-10-27 20:18 ` Coco Li
2023-10-26 8:19 ` [PATCH v4 net-next 4/6] netns-ipv4: reorganize netns_ipv4 " Coco Li
2023-10-26 9:45 ` Eric Dumazet
2023-10-26 8:19 ` [PATCH v4 net-next 5/6] net-device: reorganize net_device " Coco Li
2023-10-26 9:41 ` Eric Dumazet
2023-10-28 1:33 ` Coco Li
2023-10-26 8:19 ` [PATCH v4 net-next 6/6] tcp: reorganize tcp_sock " Coco Li
2023-10-26 10:12 ` Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231026071701.62237118@kernel.org \
--to=kuba@kernel.org \
--cc=andrew@lunn.ch \
--cc=corbet@lwn.net \
--cc=daniel@iogearbox.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=lixiaoyan@google.com \
--cc=mubashirq@google.com \
--cc=ncardwell@google.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pnemavat@google.com \
--cc=weiwan@google.com \
--cc=wwchao@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).