From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7EE54168C8 for ; Thu, 26 Oct 2023 15:47:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="YTLOXLcJ" Received: from mail-pj1-x1033.google.com (mail-pj1-x1033.google.com [IPv6:2607:f8b0:4864:20::1033]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A6AEA196 for ; Thu, 26 Oct 2023 08:47:19 -0700 (PDT) Received: by mail-pj1-x1033.google.com with SMTP id 98e67ed59e1d1-280011e94ddso425304a91.3 for ; Thu, 26 Oct 2023 08:47:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1698335239; x=1698940039; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=xlBcWVOwKivgAn0UMjWC0U1b/ad+4cMpTB3lolYhGNU=; b=YTLOXLcJyFyr5vU+nhB/v0MyiIeUegIRMB0yjXlK3hclQb8HGnkdsvHGZd7MHCqBL3 bC1RAG+f9mf2o4HcHKv7jeaISlqhUlayDQx5EgSSxT6s6FFAjUukRAjDEMDCn37HvzOe zxm7MbFTo3wuRvkK4B/VhjNUxAWl+dO/EU+KA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698335239; x=1698940039; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=xlBcWVOwKivgAn0UMjWC0U1b/ad+4cMpTB3lolYhGNU=; b=MUFMZrHGD7CBPFKc/r9ImUOzmpo0SqW4CvTz+Qzr7JfqHISqb7hOQc9HFfjTSgRqz+ IXAZPOajOlQhpNXaouSyuzXlSU7+zISQ+I6hlAIOidzRHXc+mHnYdlZQTfuecwxbmeBs gyyATka4dX3cALBZAecRKhelm6V25JHZ66HF9QyXJJIAwPh3oFrJ/lZ2H5NmveC1e4Tj wJa3k/ZyivSlg0tapTWdeOfNAyQlLZd/kO4Wi8lKLT6QeLmHLQoCHxzNrWXcWhlBd/VR OB27XKzT/tmQ2ewkvAQOYheuitQfo+g826wqYKLfCNsDscPBliOt44FyXcVxuylH/Uip dsKg== X-Gm-Message-State: AOJu0Ywv3hE4hG+8l1myhAEd3IVM7MMaeIZf6N9/NV0PBODOxO4V2Ycy mawS4TeCJAl7Phy+eqClu0nomQ== X-Google-Smtp-Source: AGHT+IE+QPVJnhPXypHjhY8uvISBKpa7dbbm+rvilNnSdebvclKGppTYd6ACyZS9wBGFhF/d0zryLA== X-Received: by 2002:a17:90a:e38a:b0:27d:36df:8472 with SMTP id b10-20020a17090ae38a00b0027d36df8472mr15374711pjz.27.1698335239138; Thu, 26 Oct 2023 08:47:19 -0700 (PDT) Received: from www.outflux.net (198-0-35-241-static.hfc.comcastbusiness.net. [198.0.35.241]) by smtp.gmail.com with ESMTPSA id 30-20020a17090a195e00b0027cfd582b51sm2008331pjh.3.2023.10.26.08.47.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 Oct 2023 08:47:18 -0700 (PDT) Date: Thu, 26 Oct 2023 08:47:17 -0700 From: Kees Cook To: Justin Stitt Cc: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Shay Agroskin , Arthur Kiyanovski , David Arinzon , Noam Dagan , Saeed Bishara , Rasesh Mody , Sudarsana Kalluru , GR-Linux-NIC-Dev@marvell.com, Dimitris Michailidis , Yisen Zhuang , Salil Mehta , Jesse Brandeburg , Tony Nguyen , Louis Peens , Shannon Nelson , Brett Creeley , drivers@pensando.io, "K. Y. Srinivasan" , Haiyang Zhang , Wei Liu , Dexuan Cui , Ronak Doshi , VMware PV-Drivers Reviewers , Andy Whitcroft , Joe Perches , Dwaipayan Ray , Lukas Bulwahn , linux-kernel@vger.kernel.org, netdev@vger.kernel.org, Nick Desaulniers , Nathan Chancellor , intel-wired-lan@lists.osuosl.org, oss-drivers@corigine.com, linux-hyperv@vger.kernel.org Subject: Re: [PATCH 0/3] ethtool: Add ethtool_puts() Message-ID: <202310260845.B2AEF3166@keescook> References: <20231025-ethtool_puts_impl-v1-0-6a53a93d3b72@google.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231025-ethtool_puts_impl-v1-0-6a53a93d3b72@google.com> On Wed, Oct 25, 2023 at 11:40:31PM +0000, Justin Stitt wrote: > @replace_2_args@ > identifier BUF; > expression VAR; > @@ > > - ethtool_sprintf > + ethtool_puts > (&BUF, VAR) I think cocci will do a better job at line folding if we adjust this rule like I had to adjust the next rule: completely remove and re-add the arguments: - ethtool_sprintf(&BUF, VAR) + ethtool_puts(&BUF, VAR) Then I think the handful of weird line wraps in the treewide patch will go away. -- Kees Cook