netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Florian Westphal <fw@strlen.de>
To: Florian Westphal <fw@strlen.de>
Cc: netdev@vger.kernel.org, steffen.klassert@secunet.com,
	herbert@gondor.apana.org.au, Antony Antony <antony@phenome.org>
Subject: Re: [PATCH ipsec-next] xfrm: policy: fix layer 4 flowi decoding
Date: Thu, 26 Oct 2023 16:38:26 +0200	[thread overview]
Message-ID: <20231026143826.GB22233@breakpoint.cc> (raw)
In-Reply-To: <20231026143642.23775-1-fw@strlen.de>

Florian Westphal <fw@strlen.de> wrote:
> +	switch (flkeys->basic.ip_proto) {
> +	case IPPROTO_GRE:
> +		fl6->fl6_gre_key = flkeys->gre.keyid;
> +		break;
> +	case IPPROTO_ICMP:

Sigh.  This should be IPPROTO_ICMPV6. I'll send a fresh v2
in a minute.

  reply	other threads:[~2023-10-26 14:38 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-04 16:09 [PATCH ipsec-next v3 0/3] xfrm: policy: replace session decode with flow dissector Florian Westphal
2023-10-04 16:09 ` [PATCH ipsec-next v3 1/3] xfrm: pass struct net to xfrm_decode_session wrappers Florian Westphal
2023-10-05 12:05   ` Simon Horman
2023-10-04 16:09 ` [PATCH ipsec-next v3 2/3] xfrm: move mark and oif flowi decode into common code Florian Westphal
2023-10-04 16:09 ` [PATCH ipsec-next v3 3/3] xfrm: policy: replace session decode with flow dissector Florian Westphal
2023-10-10  7:51 ` [PATCH ipsec-next v3 0/3] " Steffen Klassert
2023-10-26 12:12   ` Antony Antony
2023-10-26 12:57     ` Florian Westphal
2023-10-26 14:33       ` Antony Antony
2023-10-26 14:36         ` [PATCH ipsec-next] xfrm: policy: fix layer 4 flowi decoding Florian Westphal
2023-10-26 14:38           ` Florian Westphal [this message]
2023-10-26 14:45         ` [PATCH ipsec-next v2] " Florian Westphal
2023-10-28  8:31           ` Steffen Klassert

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231026143826.GB22233@breakpoint.cc \
    --to=fw@strlen.de \
    --cc=antony@phenome.org \
    --cc=herbert@gondor.apana.org.au \
    --cc=netdev@vger.kernel.org \
    --cc=steffen.klassert@secunet.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).