From: Jakub Kicinski <kuba@kernel.org>
To: Florian Fainelli <florian.fainelli@broadcom.com>
Cc: Vincent MAILHOL <mailhol.vincent@wanadoo.fr>,
netdev@vger.kernel.org, Doug Berger <opendmb@gmail.com>,
Broadcom internal kernel review list
<bcm-kernel-feedback-list@broadcom.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>, Andrew Lunn <andrew@lunn.ch>,
Heiner Kallweit <hkallweit1@gmail.com>,
Russell King <linux@armlinux.org.uk>,
Vladimir Oltean <vladimir.oltean@nxp.com>,
Tariq Toukan <tariqt@nvidia.com>, Gal Pressman <gal@nvidia.com>,
Willem de Bruijn <willemb@google.com>,
Daniil Tatianin <d-tatianin@yandex-team.ru>,
Simon Horman <horms@kernel.org>,
Justin Chen <justin.chen@broadcom.com>,
Ratheesh Kannoth <rkannoth@marvell.com>,
Joe Damato <jdamato@fastly.com>, Jiri Pirko <jiri@resnulli.us>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net-next 4/5] net: phy: broadcom: Add support for WAKE_FILTER
Date: Thu, 26 Oct 2023 14:56:44 -0700 [thread overview]
Message-ID: <20231026145644.58a8bd90@kernel.org> (raw)
In-Reply-To: <e6bd1a85-0bcf-457c-8fa8-33e68d818547@broadcom.com>
On Thu, 26 Oct 2023 10:55:10 -0700 Florian Fainelli wrote:
> >> Also, did you run parse to check your endianness conversions?
>
> I did, though nothing came out with C=1 or C=2, I might have to check
> that separately.
FWIW
drivers/net/phy/bcm-phy-lib.c:1128:42: warning: cast to restricted __be16
drivers/net/phy/bcm-phy-lib.c:1128:40: warning: incorrect type in assignment (different base types)
drivers/net/phy/bcm-phy-lib.c:1128:40: expected restricted __be16 [usertype] h_proto
drivers/net/phy/bcm-phy-lib.c:1128:40: got unsigned short [usertype]
drivers/net/phy/bcm-phy-lib.c:1188:17: warning: incorrect type in assignment (different base types)
drivers/net/phy/bcm-phy-lib.c:1188:17: expected restricted __be16 [usertype] h_proto
drivers/net/phy/bcm-phy-lib.c:1188:17: got unsigned short [usertype]
drivers/net/phy/bcm-phy-lib.c:1190:25: warning: incorrect type in assignment (different base types)
drivers/net/phy/bcm-phy-lib.c:1190:25: expected restricted __be16 [usertype] h_proto
drivers/net/phy/bcm-phy-lib.c:1190:25: got int
drivers/net/phy/bcm-phy-lib.c:1193:33: warning: incorrect type in argument 3 (different base types)
drivers/net/phy/bcm-phy-lib.c:1193:33: expected unsigned short [usertype] val
drivers/net/phy/bcm-phy-lib.c:1193:33: got restricted __be16 [usertype] h_proto
--
pw-bot: cr
next prev parent reply other threads:[~2023-10-26 21:56 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-25 17:32 [PATCH net-next 0/5] WAKE_FILTER for Broadcom PHY (v2) Florian Fainelli
2023-10-25 17:32 ` [PATCH net-next 1/5] net: ethtool: Make RXNFC walking code accept a callback Florian Fainelli
2023-10-25 17:32 ` [PATCH net-next 2/5] net: ethtool: Add validation for WAKE_FILTER Florian Fainelli
2023-10-25 17:32 ` [PATCH net-next 3/5] net: phy: Add pluming for ethtool_{get,set}_rxnfc Florian Fainelli
2023-10-25 17:32 ` [PATCH net-next 4/5] net: phy: broadcom: Add support for WAKE_FILTER Florian Fainelli
2023-10-26 1:10 ` Vincent MAILHOL
2023-10-26 2:13 ` Vincent MAILHOL
2023-10-26 17:55 ` Florian Fainelli
2023-10-26 21:56 ` Jakub Kicinski [this message]
2023-10-26 22:26 ` Florian Fainelli
2023-10-27 2:50 ` Vincent MAILHOL
2023-10-25 17:33 ` [PATCH net-next 5/5] net: bcmgenet: Interrogate PHY for WAKE_FILTER programming Florian Fainelli
2023-10-25 17:37 ` Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231026145644.58a8bd90@kernel.org \
--to=kuba@kernel.org \
--cc=andrew@lunn.ch \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=d-tatianin@yandex-team.ru \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=florian.fainelli@broadcom.com \
--cc=gal@nvidia.com \
--cc=hkallweit1@gmail.com \
--cc=horms@kernel.org \
--cc=jdamato@fastly.com \
--cc=jiri@resnulli.us \
--cc=justin.chen@broadcom.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mailhol.vincent@wanadoo.fr \
--cc=netdev@vger.kernel.org \
--cc=opendmb@gmail.com \
--cc=pabeni@redhat.com \
--cc=rkannoth@marvell.com \
--cc=tariqt@nvidia.com \
--cc=vladimir.oltean@nxp.com \
--cc=willemb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).